aboutsummaryrefslogtreecommitdiffstats
path: root/python/servo/testing_commands.py
diff options
context:
space:
mode:
authorMartin Robinson <mrobinson@igalia.com>2023-05-24 19:40:30 +0200
committerMartin Robinson <mrobinson@igalia.com>2023-05-25 16:58:05 +0200
commitdebc37a7d3269c194a21a592dacf94df9f065b4e (patch)
tree672c8b021c1ebe0bf2d7e2473e3f7c7b49547de7 /python/servo/testing_commands.py
parente9a7787a4d7e3a836853fd8b319951f20879fc83 (diff)
downloadservo-debc37a7d3269c194a21a592dacf94df9f065b4e.tar.gz
servo-debc37a7d3269c194a21a592dacf94df9f065b4e.zip
Clean up cross-compilation and features
Integrate cross-compilation and media-stack handling into the `build_like_command_arguments` decorator. This removes a lot of repetition in the code and standardizes how targets are selected for all similar commands. Now cross compilation targets, feature flags, and helper variables are stored in the CommandBase instance. This also avoids having to continuously pass these arguments down to functions called by the commands.
Diffstat (limited to 'python/servo/testing_commands.py')
-rw-r--r--python/servo/testing_commands.py5
1 files changed, 3 insertions, 2 deletions
diff --git a/python/servo/testing_commands.py b/python/servo/testing_commands.py
index f632ce30a1c..ee630be47aa 100644
--- a/python/servo/testing_commands.py
+++ b/python/servo/testing_commands.py
@@ -470,10 +470,11 @@ class MachCommands(CommandBase):
avd = "servo-x86"
target = "i686-linux-android"
print("Assuming --target " + target)
+ self.cross_compile_target = target
- env = self.build_env(target=target)
+ env = self.build_env()
os.environ["PATH"] = env["PATH"]
- assert self.handle_android_target(target)
+ assert self.setup_configuration_for_android_target(target)
apk = self.get_apk_path(release)
py = path.join(self.context.topdir, "etc", "run_in_headless_android_emulator.py")