diff options
author | Simon Sapin <simon.sapin@exyr.org> | 2019-10-24 10:27:04 +0200 |
---|---|---|
committer | Simon Sapin <simon.sapin@exyr.org> | 2019-10-24 10:30:25 +0200 |
commit | c8a49baa801d4ff445c61211b339812065709660 (patch) | |
tree | 51cec09d8f320fd7bfab0620516ce33a21ef250d /python/servo/testing_commands.py | |
parent | dc8be8f2825b7de873bf442aeb4a5dd0ed88d4b1 (diff) | |
download | servo-c8a49baa801d4ff445c61211b339812065709660.tar.gz servo-c8a49baa801d4ff445c61211b339812065709660.zip |
Add `./mach test-tidy --no-wpt`, for a git pre-push hook
Disabling WPT manifest checking brings the time it takes to run tidy
for ~11 seconds to ~3 seconds, which feels reasonable to have in a
git pre-push hook.
This can help avoid forgetting to run tidy before opening a PR.
```
$ chmod +x .git/hooks/pre-push
$ cat .git/hooks/pre-push
#!/bin/sh
set -e
./mach test-tidy --no-wpt
```
Diffstat (limited to 'python/servo/testing_commands.py')
-rw-r--r-- | python/servo/testing_commands.py | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/python/servo/testing_commands.py b/python/servo/testing_commands.py index 79b73ccc6e5..c5a6e4cc620 100644 --- a/python/servo/testing_commands.py +++ b/python/servo/testing_commands.py @@ -315,17 +315,22 @@ class MachCommands(CommandBase): @CommandArgument('--all', default=False, action="store_true", dest="all_files", help="Check all files, and run the WPT lint in tidy, " "even if unchanged") + @CommandArgument('--no-wpt', default=False, action="store_true", dest="no_wpt", + help="Skip checking that web-platform-tests manifests are up to date") @CommandArgument('--no-progress', default=False, action="store_true", help="Don't show progress for tidy") @CommandArgument('--self-test', default=False, action="store_true", help="Run unit tests for tidy") @CommandArgument('--stylo', default=False, action="store_true", help="Only handle files in the stylo tree") - def test_tidy(self, all_files, no_progress, self_test, stylo): + def test_tidy(self, all_files, no_wpt, no_progress, self_test, stylo): if self_test: return test_tidy.do_tests() else: - manifest_dirty = run_update(self.context.topdir, check_clean=True) + if no_wpt: + manifest_dirty = False + else: + manifest_dirty = run_update(self.context.topdir, check_clean=True) tidy_failed = tidy.scan(not all_files, not no_progress, stylo=stylo) self.install_rustfmt() rustfmt_failed = self.call_rustup_run(["cargo", "fmt", "--", "--check"]) |