aboutsummaryrefslogtreecommitdiffstats
path: root/python/servo/testing_commands.py
diff options
context:
space:
mode:
authorKevin Liu <mail@nivekuil.com>2016-09-29 12:03:49 -0700
committerKevin Liu <mail@nivekuil.com>2016-09-29 16:46:34 -0700
commitb3a0ff5f310d6cbd1f9a440659128a8a2e4ced97 (patch)
tree0c270f05b013709337d91a9b03d3282dad7627c0 /python/servo/testing_commands.py
parentce6d7a735f8b59a219bb20c9ffe930c52d527dbd (diff)
downloadservo-b3a0ff5f310d6cbd1f9a440659128a8a2e4ced97.tar.gz
servo-b3a0ff5f310d6cbd1f9a440659128a8a2e4ced97.zip
Return the error codes instead of implicitly returning None
Diffstat (limited to 'python/servo/testing_commands.py')
-rw-r--r--python/servo/testing_commands.py17
1 files changed, 4 insertions, 13 deletions
diff --git a/python/servo/testing_commands.py b/python/servo/testing_commands.py
index 5f7a9e1fd1d..e1ea6627afd 100644
--- a/python/servo/testing_commands.py
+++ b/python/servo/testing_commands.py
@@ -246,9 +246,7 @@ class MachCommands(CommandBase):
if features:
args += ["--features", "%s" % ' '.join(features)]
- result = call(args, env=env, cwd=self.servo_crate())
- if result != 0:
- return result
+ return call(args, env=env, cwd=self.servo_crate())
# Run style tests with the testing feature
if has_style:
@@ -257,9 +255,7 @@ class MachCommands(CommandBase):
args += ["%s" % ' '.join(features + ["testing"])]
else:
args += ["testing"]
- result = call(args, env=env, cwd=self.servo_crate())
- if result != 0:
- return result
+ return call(args, env=env, cwd=self.servo_crate())
@Command('test-stylo',
description='Run stylo unit tests',
@@ -273,10 +269,7 @@ class MachCommands(CommandBase):
env["CARGO_TARGET_DIR"] = path.join(self.context.topdir, "target", "geckolib").encode("UTF-8")
with cd(path.join("ports", "geckolib")):
- result = call(["cargo", "test", "-p", "stylo_tests"], env=env)
-
- if result != 0:
- return result
+ return call(["cargo", "test", "-p", "stylo_tests"], env=env)
@Command('test-compiletest',
description='Run compiletests',
@@ -333,9 +326,7 @@ class MachCommands(CommandBase):
else:
env["BUILD_MODE"] = "debug"
- result = call(args, env=env, cwd=self.servo_crate())
- if result != 0:
- return result
+ return call(args, env=env, cwd=self.servo_crate())
@Command('test-content',
description='Run the content tests',