diff options
| author | Martin Robinson <mrobinson@igalia.com> | 2023-05-18 09:08:43 +0200 |
|---|---|---|
| committer | Martin Robinson <mrobinson@igalia.com> | 2023-05-18 09:08:43 +0200 |
| commit | 6e2d1bdc7932b50e8c6e0f20a05096c6b5863467 (patch) | |
| tree | 830905e874af42a141ef30dcaa32e826670918ba /python/servo/testing_commands.py | |
| parent | e09f85e17bd504a4c1c218ad14fa1a0ecbcaa839 (diff) | |
| download | servo-6e2d1bdc7932b50e8c6e0f20a05096c6b5863467.tar.gz servo-6e2d1bdc7932b50e8c6e0f20a05096c6b5863467.zip | |
Thread panics should be a hard-fail in smoketests
This prevents, for instance, a script thread panic from hanging Servo
and means those kind of panics won't cause CI to hang.
Fixes #29749.
Diffstat (limited to 'python/servo/testing_commands.py')
| -rw-r--r-- | python/servo/testing_commands.py | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/python/servo/testing_commands.py b/python/servo/testing_commands.py index 9209e9240d8..01c5882ca2c 100644 --- a/python/servo/testing_commands.py +++ b/python/servo/testing_commands.py @@ -835,6 +835,9 @@ testing/web-platform/mozilla/tests for Servo-only tests""" % reference_path) @CommandArgument('params', nargs='...', help="Command-line arguments to be passed through to Servo") def smoketest(self, params): - params = params + ['tests/html/close-on-load.html'] + # We pass `-f` here so that any thread panic will cause Servo to exit, + # preventing a panic from hanging execution. This means that these kind + # of panics won't cause timeouts on CI. + params = params + ['-f', 'tests/html/close-on-load.html'] return self.context.commands.dispatch( 'run', self.context, params=params) |