diff options
author | Mitchell Hentges <mitchhentges@protonmail.com> | 2016-05-19 19:55:54 +0200 |
---|---|---|
committer | Mitchell Hentges <mitchhentges@protonmail.com> | 2016-05-25 21:17:22 +0200 |
commit | 52507c80a04890c4c3077785980e79872150f594 (patch) | |
tree | b983659480302c1b8036f4c1fd5d7dbea8849e1f /python/servo/testing_commands.py | |
parent | 8876d1f00213207d42089c1282abb8d1b5bef8b6 (diff) | |
download | servo-52507c80a04890c4c3077785980e79872150f594.tar.gz servo-52507c80a04890c4c3077785980e79872150f594.zip |
Remove --faster flag from test-tidy, go fast by default. Fixes 11217
Diffstat (limited to 'python/servo/testing_commands.py')
-rw-r--r-- | python/servo/testing_commands.py | 21 |
1 files changed, 3 insertions, 18 deletions
diff --git a/python/servo/testing_commands.py b/python/servo/testing_commands.py index 939b3434341..4495b40c667 100644 --- a/python/servo/testing_commands.py +++ b/python/servo/testing_commands.py @@ -255,33 +255,18 @@ class MachCommands(CommandBase): @Command('test-tidy', description='Run the source code tidiness check', category='testing') - @CommandArgument('--faster', default=False, action="store_true", - help="Only check changed files and skip the WPT lint in tidy, " - "if there are no changes in the WPT files. Cannot be used with --all") @CommandArgument('--all', default=False, action="store_true", dest="all_files", help="Check all files, and run the WPT lint in tidy, " - "even if unchanged. Cannot be used with --faster") + "even if unchanged") @CommandArgument('--no-progress', default=False, action="store_true", help="Don't show progress for tidy") @CommandArgument('--self-test', default=False, action="store_true", help="Run unit tests for tidy") - def test_tidy(self, faster, all_files, no_progress, self_test): + def test_tidy(self, all_files, no_progress, self_test): if self_test: return test_tidy.do_tests() else: - # The `test-tidy` command is currently mid-migration from --faster to --all. - # Since --faster and --all are opposites, they cannot both be used at the same time - if faster and all_files: - print("Cannot tidy --all while also being --faster") - return -1 - - # |--faster|--all|behaviour of tidy.scan() - # | false|false|scan all files # This was the behaviour before adding --all - # | true|false|only scan changed files # Expected behaviour if --faster is used - # | false| true|scan all files # Expected behaviour if --all is used - # - # The pattern: if `faster` is true, go fast. Otherwise, go slow. - return tidy.scan(faster, not no_progress) + return tidy.scan(not all_files, not no_progress) @Command('test-webidl', description='Run the WebIDL parser tests', |