aboutsummaryrefslogtreecommitdiffstats
path: root/python/servo/testing_commands.py
diff options
context:
space:
mode:
authorMs2ger <Ms2ger@gmail.com>2016-05-30 09:34:51 +0200
committerMs2ger <Ms2ger@gmail.com>2016-05-30 09:34:51 +0200
commit3535f3f6c25b6e380d190559a5ca03ea70282fe0 (patch)
tree07406729cff3f9cde20f9811e46ccbb17b5ffe37 /python/servo/testing_commands.py
parentb11648903bb07a31ec93f3030058ed41b3472b17 (diff)
downloadservo-3535f3f6c25b6e380d190559a5ca03ea70282fe0.tar.gz
servo-3535f3f6c25b6e380d190559a5ca03ea70282fe0.zip
Warn me when I try to sync upstream tests without requesting a commit.
This default invariably wastes my time, and I'm about the only person using the sync argument.
Diffstat (limited to 'python/servo/testing_commands.py')
-rw-r--r--python/servo/testing_commands.py10
1 files changed, 10 insertions, 0 deletions
diff --git a/python/servo/testing_commands.py b/python/servo/testing_commands.py
index 4a3e0b844bc..e42663b75e6 100644
--- a/python/servo/testing_commands.py
+++ b/python/servo/testing_commands.py
@@ -348,6 +348,11 @@ class MachCommands(CommandBase):
self.ensure_bootstrapped()
run_file = path.abspath(path.join("tests", "wpt", "update.py"))
kwargs["no_patch"] = not patch
+
+ if kwargs["no_patch"] and kwargs["sync"]:
+ print("Are you sure you don't want a patch?")
+ return 1
+
run_globals = {"__file__": run_file}
execfile(run_file, run_globals)
return run_globals["update_tests"](**kwargs)
@@ -403,6 +408,11 @@ class MachCommands(CommandBase):
self.ensure_bootstrapped()
run_file = path.abspath(path.join("tests", "wpt", "update_css.py"))
kwargs["no_patch"] = not patch
+
+ if kwargs["no_patch"] and kwargs["sync"]:
+ print("Are you sure you don't want a patch?")
+ return 1
+
run_globals = {"__file__": run_file}
execfile(run_file, run_globals)
return run_globals["update_tests"](**kwargs)