diff options
| author | Martin Robinson <mrobinson@igalia.com> | 2024-01-18 17:12:04 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-01-18 16:12:04 +0000 |
| commit | c641c589e5f18e461887bdb67528425fe683715d (patch) | |
| tree | ead3a8fd4788a181f041fd363efb067e9bb2e31c /python/servo/post_build_commands.py | |
| parent | 8e5f28839cde6b9ee5cd7cb4f8c27ff0ae10a86c (diff) | |
| download | servo-c641c589e5f18e461887bdb67528425fe683715d.tar.gz servo-c641c589e5f18e461887bdb67528425fe683715d.zip | |
build: Use `--keep-going` in `./mach doc` (#31119)
The documentation build for `gstreamer-gl-x11` depends on nightly Rust
for some reason, which breaks our doc build. Use `--keep-going` to
prevent breakage in dependencies from breaking our doc build. This
unfortunately hides issues in our own documentation build.
NB: It isn't possible to exclude dependencies with `--exclude` unless
you are using `--workspace`. We would probably like to do that, but we
have crates with the same name, preventing using `--workspace`.
Diffstat (limited to 'python/servo/post_build_commands.py')
| -rw-r--r-- | python/servo/post_build_commands.py | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/python/servo/post_build_commands.py b/python/servo/post_build_commands.py index 0af43c9f199..bd9382b55a1 100644 --- a/python/servo/post_build_commands.py +++ b/python/servo/post_build_commands.py @@ -266,6 +266,11 @@ class PostBuildCommands(CommandBase): else: copy2(full_name, destination) + # Documentation build errors shouldn't cause the entire build to fail. This + # prevents issues with dependencies from breaking our documentation build, + # with the downside that it hides documentation issues. + params.insert(0, "--keep-going") + env = self.build_env() returncode = self.run_cargo_build_like_command("doc", params, env=env, **kwargs) if returncode: |