diff options
| author | Mukilan Thiyagarajan <mukilan@igalia.com> | 2024-08-26 18:38:21 +0530 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-08-26 13:08:21 +0000 |
| commit | b6d5ac09b0b2acbb0f5b00232e53d0111a159063 (patch) | |
| tree | 18842738e78794ba096a0af44b16d37695cff6d7 /python/servo/platform/linux.py | |
| parent | 4397d8a02156a009d16d8b79796b1e54ca635624 (diff) | |
| download | servo-b6d5ac09b0b2acbb0f5b00232e53d0111a159063.tar.gz servo-b6d5ac09b0b2acbb0f5b00232e53d0111a159063.zip | |
mach: introduce `BuildTarget` abstraction (#33114)
Introduce a new `BuildTarget` abstraction to centralize the code for
supporting different ways of choosing the build target (e.g --android,
--target x86_64-linux-android , --target aarch64-linux-ohos). This
is currently handled in an adhoc fashion in different commands (
mach package, install, run) leading to a proliferation of keyword
parameters for the commands and duplicated logic.
The patch introduces a new `allow_target_configuration` decorator to
do the validation and parsing of these parameters into the appropriate
`BuildTarget` subclass, which is now stored as an instance attribute
of the CommandBase class. All the code that previously relied on
`self.cross_compile_target` has been switched to use the BuildTarget.
Signed-off-by: Mukilan Thiyagarajan <mukilan@igalia.com>
Diffstat (limited to 'python/servo/platform/linux.py')
| -rw-r--r-- | python/servo/platform/linux.py | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/python/servo/platform/linux.py b/python/servo/platform/linux.py index 6ed34ee9892..1397a4f16de 100644 --- a/python/servo/platform/linux.py +++ b/python/servo/platform/linux.py @@ -7,12 +7,13 @@ # option. This file may not be copied, modified, or distributed # except according to those terms. +import distro import os import subprocess from typing import Optional, Tuple -import distro from .base import Base +from .build_target import BuildTarget # Please keep these in sync with the packages on the wiki, using the instructions below # https://github.com/servo/servo/wiki/Building @@ -211,10 +212,10 @@ class Linux(Base): raise EnvironmentError("Installation of dependencies failed.") return True - def gstreamer_root(self, cross_compilation_target: Optional[str]) -> Optional[str]: + def gstreamer_root(self, _target: BuildTarget) -> Optional[str]: return None - def _platform_bootstrap_gstreamer(self, _force: bool) -> bool: + def _platform_bootstrap_gstreamer(self, _target: BuildTarget, _force: bool) -> bool: raise EnvironmentError( "Bootstrapping GStreamer on Linux is not supported. " + "Please install it using your distribution package manager.") |