aboutsummaryrefslogtreecommitdiffstats
path: root/python/servo/platform/base.py
diff options
context:
space:
mode:
authorMartin Robinson <mrobinson@igalia.com>2024-01-05 12:14:17 +0100
committerGitHub <noreply@github.com>2024-01-05 11:14:17 +0000
commit9a1d7aabd71fe82c9420abdc33a6a9ba0f8eac52 (patch)
tree4b0bd21a11fdd2c6d0f96fee25f4e76e22530f6c /python/servo/platform/base.py
parentafb0d4c56ed98c4a16fe51d9cf051cc351aba16f (diff)
downloadservo-9a1d7aabd71fe82c9420abdc33a6a9ba0f8eac52.tar.gz
servo-9a1d7aabd71fe82c9420abdc33a6a9ba0f8eac52.zip
bootstrap: Adding more output when installing dependencies (#31003)
It's often the case (especially with the taplo installation and on Windows) that bootstrap is doing lots of stuff in the background for a long amount of time. Without output it's hard to tell what exactly is going on. This change adds more output to this process as well as removing some Pythong 2.x era code.
Diffstat (limited to 'python/servo/platform/base.py')
-rw-r--r--python/servo/platform/base.py8
1 files changed, 4 insertions, 4 deletions
diff --git a/python/servo/platform/base.py b/python/servo/platform/base.py
index eee42428e56..39d7ae5f293 100644
--- a/python/servo/platform/base.py
+++ b/python/servo/platform/base.py
@@ -102,8 +102,8 @@ class Base:
if not force and shutil.which("taplo") is not None:
return False
- if subprocess.call(["cargo", "install", "taplo-cli", "--locked"],
- stdout=subprocess.PIPE, stderr=subprocess.PIPE) != 0:
+ print(" * Installing taplo...")
+ if subprocess.call(["cargo", "install", "taplo-cli", "--locked"]) != 0:
raise EnvironmentError("Installation of taplo failed.")
return True
@@ -114,8 +114,8 @@ class Base:
env = dict(os.environ)
env["CARGO_BUILD_RUSTC"] = "rustc"
- if subprocess.call(["cargo", "install", "--path", "support/crown"],
- stdout=subprocess.PIPE, stderr=subprocess.PIPE, env=env) != 0:
+ print(" * Installing crown (the Servo linter)...")
+ if subprocess.call(["cargo", "install", "--path", "support/crown"], env=env) != 0:
raise EnvironmentError("Installation of crown failed.")
return True