aboutsummaryrefslogtreecommitdiffstats
path: root/python/servo/package_commands.py
diff options
context:
space:
mode:
authorbors-servo <lbergstrom+bors@mozilla.com>2018-03-24 13:46:20 -0400
committerGitHub <noreply@github.com>2018-03-24 13:46:20 -0400
commit23b2f42a368cdc68548310e79b31306f40f95553 (patch)
tree289e52ae449e9a101295e275f5d011288835d46c /python/servo/package_commands.py
parent2d789646345a21c32f9bed0f7380526469384238 (diff)
parent80304a133f66ba4bda0070d29a36043d8f4b4334 (diff)
downloadservo-23b2f42a368cdc68548310e79b31306f40f95553.tar.gz
servo-23b2f42a368cdc68548310e79b31306f40f95553.zip
Auto merge of #20406 - kwonoj:feat-fetch-body-arraybuffer, r=jdm
feat(fetch): accept arraybuffer in consume_body <!-- Please describe your changes on the following line: --> Related to https://github.com/servo/servo/issues/20346. I realized I am not sufficiently knowledgeable about codebases and have high confidence this PR is not ready to be accepted. Raising it as PR early to possibly ask some suggestions around codebases. If this PR seems unrecoverable by code review, please feel freely close and unassign me from issue πŸ™ This PR tries to implement #20346, updating `Body` idl and implements corresponding implementation in `body.rs` for `fetch`. Criteria for changes may includes - does `run_array_buffer_data_algorithm` implementation is legit for allocating arraybuffer? (probably not) - does `run_array_buffer_data_algorithm` implementation is acceptable for handling error, by naively returning `Error::JSFailed`? - there are some number of wpt test started to PASS with this PR. Is this legit side effect, or something incorrect by current implementation? - etcs, vice versa --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #20346 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ - wpt test has changed in PR, need to be reviewed. <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20406) <!-- Reviewable:end -->
Diffstat (limited to 'python/servo/package_commands.py')
0 files changed, 0 insertions, 0 deletions