aboutsummaryrefslogtreecommitdiffstats
path: root/python/servo/package_commands.py
diff options
context:
space:
mode:
authorAneesh Agrawal <aneeshusa@gmail.com>2017-05-30 19:39:06 -0400
committerAneesh Agrawal <aneeshusa@gmail.com>2017-05-30 19:39:06 -0400
commit3cf15cc86da12cf28a9486a87ee44381067a576c (patch)
tree5de0f4531b7d41e6713d6c0221420af4bf049bb5 /python/servo/package_commands.py
parent1428077c024502aeebc7a02310404ee28837e06b (diff)
downloadservo-3cf15cc86da12cf28a9486a87ee44381067a576c.tar.gz
servo-3cf15cc86da12cf28a9486a87ee44381067a576c.zip
Shim subprocess.DEVNULL for Python 2
This was introduced in Python 3.3, so provide our own version.
Diffstat (limited to 'python/servo/package_commands.py')
-rw-r--r--python/servo/package_commands.py16
1 files changed, 9 insertions, 7 deletions
diff --git a/python/servo/package_commands.py b/python/servo/package_commands.py
index 67da3f83d5c..d7ae4567b38 100644
--- a/python/servo/package_commands.py
+++ b/python/servo/package_commands.py
@@ -490,13 +490,15 @@ class PackageCommands(CommandBase):
'--message=Version Bump: {}'.format(brew_version),
])
- token = os.environ['GITHUB_HOMEBREW_TOKEN']
- call_git([
- 'push',
- '-qf',
- 'https://{}@github.com/servo/homebrew-servo.git'.format(token),
- 'master',
- ], stdout=subprocess.DEVNULL, stderr=subprocess.DEVNULL)
+ push_url = 'https://{}@github.com/servo/homebrew-servo.git'
+ # TODO(aneeshusa): Use subprocess.DEVNULL with Python 3.3+
+ with open(os.devnull, 'wb') as DEVNULL:
+ call_git([
+ 'push',
+ '-qf',
+ push_url.format(os.environ['GITHUB_HOMEBREW_TOKEN']),
+ 'master',
+ ], stdout=DEVNULL, stderr=DEVNULL)
timestamp = datetime.utcnow().replace(microsecond=0)
for package in PACKAGES[platform]: