diff options
author | bors-servo <infra@servo.org> | 2023-04-13 10:02:35 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2023-04-13 10:02:35 +0200 |
commit | 15f966bde5985d02b4a35b1078d44a3023dcf382 (patch) | |
tree | ae3aeaba1d7576c63da0f569ba251747fb62bcb2 /python/servo/devenv_commands.py | |
parent | 7ab48556b04e327939df8a066de10de68cdd4bd5 (diff) | |
parent | 492091e5b0cfbee3d4e988d699bd910e2cd806fa (diff) | |
download | servo-15f966bde5985d02b4a35b1078d44a3023dcf382.tar.gz servo-15f966bde5985d02b4a35b1078d44a3023dcf382.zip |
Auto merge of #29610 - mrobinson:notify, r=mukilan
Use notify-py to send notifications
- Use notify-py to send notifications, but use a custom notifier on
Linux since transient (ie non-sticky) notifications are not supported.
- Add an icon to the notification.
- Don't send a notification after doing `./mach check` because that
can trigger notifications when `rust-analyzer` is working.
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes do not require tests because they just change build notifications.
<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Diffstat (limited to 'python/servo/devenv_commands.py')
-rw-r--r-- | python/servo/devenv_commands.py | 7 |
1 files changed, 0 insertions, 7 deletions
diff --git a/python/servo/devenv_commands.py b/python/servo/devenv_commands.py index 5570aae50b7..47df6599b92 100644 --- a/python/servo/devenv_commands.py +++ b/python/servo/devenv_commands.py @@ -9,7 +9,6 @@ from __future__ import print_function, unicode_literals from os import path, listdir, getcwd -from time import time import json import signal @@ -25,7 +24,6 @@ from mach.decorators import ( ) from servo.command_base import CommandBase, cd, call -from servo.build_commands import notify_build_done from servo.util import get_static_rust_lang_org_dist, get_urlopen_kwargs @@ -53,12 +51,7 @@ class MachCommands(CommandBase): self.ensure_clobbered() env = self.build_env() - build_start = time() status = self.run_cargo_build_like_command("check", params, env=env, features=features, **kwargs) - elapsed = time() - build_start - - notify_build_done(self.config, elapsed, status == 0) - if status == 0: print('Finished checking, binary NOT updated. Consider ./mach build before ./mach run') |