diff options
author | Martin Robinson <mrobinson@igalia.com> | 2023-04-10 14:46:08 +0200 |
---|---|---|
committer | Martin Robinson <mrobinson@igalia.com> | 2023-04-13 10:01:25 +0200 |
commit | 492091e5b0cfbee3d4e988d699bd910e2cd806fa (patch) | |
tree | 7cda5737ab680fe1d4c6ee6c92089fd62ed45cba /python/servo/devenv_commands.py | |
parent | 53218621e934f5cb66681b22d3d91c3bbcb0d4bc (diff) | |
download | servo-492091e5b0cfbee3d4e988d699bd910e2cd806fa.tar.gz servo-492091e5b0cfbee3d4e988d699bd910e2cd806fa.zip |
Use notify-py to send notifications
- Use notify-py to send notifications, but use a custom notifier on
Linux since transient (ie non-sticky) notifications are not supported.
- Add an icon to the notification.
- Don't send a notification after doing `./mach check` because that
can trigger notifications when `rust-analyzer` is working.
Diffstat (limited to 'python/servo/devenv_commands.py')
-rw-r--r-- | python/servo/devenv_commands.py | 7 |
1 files changed, 0 insertions, 7 deletions
diff --git a/python/servo/devenv_commands.py b/python/servo/devenv_commands.py index db44ad2121c..33d8af9f320 100644 --- a/python/servo/devenv_commands.py +++ b/python/servo/devenv_commands.py @@ -9,7 +9,6 @@ from __future__ import print_function, unicode_literals from os import path, listdir, getcwd -from time import time import signal import sys @@ -25,7 +24,6 @@ from mach.decorators import ( ) from servo.command_base import CommandBase, cd, call -from servo.build_commands import notify_build_done from servo.util import get_static_rust_lang_org_dist, get_urlopen_kwargs @@ -53,12 +51,7 @@ class MachCommands(CommandBase): self.ensure_clobbered() env = self.build_env() - build_start = time() status = self.run_cargo_build_like_command("check", params, env=env, features=features, **kwargs) - elapsed = time() - build_start - - notify_build_done(self.config, elapsed, status == 0) - if status == 0: print('Finished checking, binary NOT updated. Consider ./mach build before ./mach run') |