aboutsummaryrefslogtreecommitdiffstats
path: root/python/servo/command_base.py
diff options
context:
space:
mode:
authorSimon Sapin <simon.sapin@exyr.org>2018-01-04 17:47:38 +0100
committerSimon Sapin <simon.sapin@exyr.org>2018-01-10 20:54:35 +0100
commitc8f542afacce91a71e7805f7b610d5ec66195b8d (patch)
tree409f89abc330af81c07248d640886c0fbb32f51a /python/servo/command_base.py
parent59bb421ea107adfeb0c986c58f2f50da420dbb5a (diff)
downloadservo-c8f542afacce91a71e7805f7b610d5ec66195b8d.tar.gz
servo-c8f542afacce91a71e7805f7b610d5ec66195b8d.zip
We use Nigthly Cargo with Stable Rust
Nightly now has incremental compilation as a stable feature, but that’s not in the stable channel yet.
Diffstat (limited to 'python/servo/command_base.py')
-rw-r--r--python/servo/command_base.py5
1 files changed, 2 insertions, 3 deletions
diff --git a/python/servo/command_base.py b/python/servo/command_base.py
index 1f3d784ebc3..bfc7192df97 100644
--- a/python/servo/command_base.py
+++ b/python/servo/command_base.py
@@ -297,9 +297,8 @@ class CommandBase(object):
def set_use_geckolib_toolchain(self, use_geckolib_toolchain=True):
self._use_geckolib_toolchain = use_geckolib_toolchain
if use_geckolib_toolchain:
- # Cargo maintainer's position is that CARGO_INCREMENTAL is a nightly-only feature
- # and should not be used on the stable channel.
- # https://github.com/rust-lang/cargo/issues/3835
+ # We use Cargo Nightly 1.24 with Rust 1.22,
+ # it passes `-C incremental` to rustc, which is new in Rust 1.24.
self.config["build"]["incremental"] = False
def toolchain(self):