aboutsummaryrefslogtreecommitdiffstats
path: root/python/servo/command_base.py
diff options
context:
space:
mode:
authorbors-servo <lbergstrom+bors@mozilla.com>2017-09-28 09:06:48 -0500
committerGitHub <noreply@github.com>2017-09-28 09:06:48 -0500
commit2c73736f7dc52798a1af47d330b5690fc91fece8 (patch)
tree252e09beb20b3a200735a69b6a3d87984004d6a5 /python/servo/command_base.py
parent7574d2647699e211638379f8f89760c57a1d6cc8 (diff)
parentdba19f53f5a9ea0b849b8b04ab6e08e41db74778 (diff)
downloadservo-2c73736f7dc52798a1af47d330b5690fc91fece8.tar.gz
servo-2c73736f7dc52798a1af47d330b5690fc91fece8.zip
Auto merge of #18660 - upsuper:var-sub-inherit, r=emilio
Don't use inherited custom properties for substitution <!-- Please describe your changes on the following line: --> Custom properties from parent node has been considered in early stage of cascading them (in [`custom_properties::cascade`](https://github.com/servo/servo/blob/01adcf69d794b09396ea469a4fe2ca3324ef9306/components/style/custom_properties.rs#L461-L469)), and there is nothing in the spec stating that substitution should take inherited values into consideration when the value is invalid in the current node. Actually, there is a web-platform test explicitly checks that inherited value is not taken when the value is computed to invalid. This would fix [bug 1402217](https://bugzilla.mozilla.org/show_bug.cgi?id=1402217). --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18660) <!-- Reviewable:end -->
Diffstat (limited to 'python/servo/command_base.py')
0 files changed, 0 insertions, 0 deletions