aboutsummaryrefslogtreecommitdiffstats
path: root/python/servo/command_base.py
diff options
context:
space:
mode:
authorJonathan Schwender <55576758+jschwe@users.noreply.github.com>2024-09-27 08:11:57 +0200
committerGitHub <noreply@github.com>2024-09-27 06:11:57 +0000
commit78370fa6d082f60cd6fe41a24e98fa52e90dbf1c (patch)
treecc3067907c18d757d693a6102c71496e2f7e2e41 /python/servo/command_base.py
parent02953d2fb69413f358210770d10d77efc6d015bd (diff)
downloadservo-78370fa6d082f60cd6fe41a24e98fa52e90dbf1c.tar.gz
servo-78370fa6d082f60cd6fe41a24e98fa52e90dbf1c.zip
Fix mach run bustage (#33563)
Move `--flavor` to a new "Packaging options" group, so that we can only apply the flavor option to the commands that support it. Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
Diffstat (limited to 'python/servo/command_base.py')
-rw-r--r--python/servo/command_base.py18
1 files changed, 13 insertions, 5 deletions
diff --git a/python/servo/command_base.py b/python/servo/command_base.py
index 1436aa41379..1dcfe1e8408 100644
--- a/python/servo/command_base.py
+++ b/python/servo/command_base.py
@@ -515,7 +515,11 @@ class CommandBase(object):
return env
@staticmethod
- def common_command_arguments(build_configuration=False, build_type=False, binary_selection=False):
+ def common_command_arguments(build_configuration=False,
+ build_type=False,
+ binary_selection=False,
+ package_configuration=False
+ ):
decorators = []
if build_type or binary_selection:
decorators += [
@@ -532,10 +536,6 @@ class CommandBase(object):
CommandArgument('--profile', group="Build Type",
help='Build with custom Cargo profile'),
CommandArgument('--with-asan', action='store_true', help="Build with AddressSanitizer"),
- CommandArgument(
- '--flavor', default=None, group="Build Type",
- help='Product flavor to be used when packaging with Gradle/Hvigor (android/ohos).'
- ),
]
if build_configuration:
@@ -594,6 +594,14 @@ class CommandBase(object):
help="Enable Servo's `crown` linter tool"
)
]
+ if package_configuration:
+ decorators += [
+ CommandArgumentGroup('Packaging options'),
+ CommandArgument(
+ '--flavor', default=None, group="Packaging options",
+ help='Product flavor to be used when packaging with Gradle/Hvigor (android/ohos).'
+ ),
+ ]
if binary_selection:
decorators += [