diff options
author | bors-servo <lbergstrom+bors@mozilla.com> | 2019-07-24 11:54:47 -0400 |
---|---|---|
committer | GitHub <noreply@github.com> | 2019-07-24 11:54:47 -0400 |
commit | 9b14bbdc98ea078a4f868abee1b7c7244161f46d (patch) | |
tree | c3061b4cc48e42c8fa247d43cdd0f263e70be0df /python/servo/build_commands.py | |
parent | 410c8e5085b45d5d0628159cecc3df05f82ac87d (diff) | |
parent | 88cacfb0098e20be70c27bfde6b74cd3290f1fe4 (diff) | |
download | servo-9b14bbdc98ea078a4f868abee1b7c7244161f46d.tar.gz servo-9b14bbdc98ea078a4f868abee1b7c7244161f46d.zip |
Auto merge of #23816 - marmeladema:issue-20377, r=jdm
Wrapping unsafe raw JSContext pointers in a safe struct. Part 1.
Wrapping unsafe raw JSContext pointers in a safe struct. Issue #20377.
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] create a struct JSContext(*mut jsapi::JSContext) type
- [x] implement Deref for this new type so it's easy to obtain the inner context pointer
- [x] add an unsafe from_ptr static method that returns a new instance of the type
- [x] start by changing various Argument uses in CodegenRust.py for python classes that inherit from CGAbstractMethod
- [x] convert the python code that interacts with CGClass (CGCallback, CGCallbackFunction, CGCallbackFunctionImpl, CGCallbackInterface) and any rust code that interacts with it
- [x] update CGDictionary and any rust code that interacts with it
- [x] make the code generator declare trait methods that accept the new type instead of *mut JSContext (CGInterfaceTrait)
- [x] modify GlobalScope::get_cx to return a SafeJSContext
<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23816)
<!-- Reviewable:end -->
Diffstat (limited to 'python/servo/build_commands.py')
0 files changed, 0 insertions, 0 deletions