diff options
| author | Martin Robinson <mrobinson@igalia.com> | 2023-08-15 16:49:05 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-08-15 14:49:05 +0000 |
| commit | 83a46f68db17de3b84596c4af97e73dbcf7abd6a (patch) | |
| tree | 16776909b4756dc96322b832439a8ccffa38e76d /python/servo/build_commands.py | |
| parent | 16445983ececfcdf80a4dd84412268b560031b4e (diff) | |
| download | servo-83a46f68db17de3b84596c4af97e73dbcf7abd6a.tar.gz servo-83a46f68db17de3b84596c4af97e73dbcf7abd6a.zip | |
Replace "-mmacosx-version-min" with MACOSX_DEPLOYMENT_TARGET (#30102)
It's unclear if the compiler flag was doing anything, but I've verified
(with otool) that the environment variable does affect the minimum
version of the MacOS set in the binary. We could examine later if this
is still necessary.
This was added in #23163 when switching CI from gcc to clang.
Diffstat (limited to 'python/servo/build_commands.py')
| -rw-r--r-- | python/servo/build_commands.py | 7 |
1 files changed, 1 insertions, 6 deletions
diff --git a/python/servo/build_commands.py b/python/servo/build_commands.py index f0968a235bf..4b0858f6ff1 100644 --- a/python/servo/build_commands.py +++ b/python/servo/build_commands.py @@ -79,15 +79,10 @@ class MachCommands(CommandBase): build_start = time() host = servo.platform.host_triple() - target_triple = self.cross_compile_target or servo.platform.host_triple() - if 'apple-darwin' in host and target_triple == host: - if 'CXXFLAGS' not in env: - env['CXXFLAGS'] = '' - env["CXXFLAGS"] += "-mmacosx-version-min=10.10" - if 'windows' in host: vs_dirs = self.vs_dirs() + target_triple = self.cross_compile_target or servo.platform.host_triple() if host != target_triple and 'windows' in target_triple: if os.environ.get('VisualStudioVersion') or os.environ.get('VCINSTALLDIR'): print("Can't cross-compile for Windows inside of a Visual Studio shell.\n" |