diff options
author | Emilio Cobos Álvarez <emilio@crisal.io> | 2017-04-28 02:15:19 +0200 |
---|---|---|
committer | Emilio Cobos Álvarez <emilio@crisal.io> | 2017-04-28 02:57:54 +0200 |
commit | 7a556a7f03a64d8cf3d128590bf5bbc66813137f (patch) | |
tree | b02314f0046cf44cef1f9a3d916a1feadf326214 /python/servo/bootstrap_commands.py | |
parent | 04aac0247aea29e361589a75954b4f769478dd02 (diff) | |
download | servo-7a556a7f03a64d8cf3d128590bf5bbc66813137f.tar.gz servo-7a556a7f03a64d8cf3d128590bf5bbc66813137f.zip |
Bug 1360399: Don't deduplicate revalidation selectors. r=bholley
It's unfortunate, but it's a correctness issue. I was looking at the
expectations update here:
* https://hg.mozilla.org/integration/autoland/rev/659cddddd434
And investigating it I realised that it's wrong to coalesce selectors like that,
because we keep the bloom filter flags.
So in the test cases disabled, we have a selector that looks like this:
msub > :not(:first-child),
msup > :not(:first-child),
msubsup > :not(:first-child),
mmultiscripts > :not(:first-child) {
-moz-script-level: +1;
-moz-math-display: inline;
}
And an element that looks like this:
<msubsup><mi></mi><mi></mi></msubsup>
We're only inserting the first selector msub > :not(:first-child) into the set,
so when we're going to match the <mi> elements we fast-reject it in both cases
due to the bloom filter, so they share style.
I can't see an easy way to fix this keeping the deduplication. If we keep it, we
need to remove the bloom filter optimization, which means that we'd trash the
cache for every first-child in the document (the :not(:first-child) effectively
becomes a global rule).
MozReview-Commit-ID: 9VPkmdj9zDg
Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
Diffstat (limited to 'python/servo/bootstrap_commands.py')
0 files changed, 0 insertions, 0 deletions