aboutsummaryrefslogtreecommitdiffstats
path: root/python/mach/setup.py
diff options
context:
space:
mode:
authorbors-servo <servo-ops@mozilla.com>2021-12-15 16:57:01 -0500
committerGitHub <noreply@github.com>2021-12-15 16:57:01 -0500
commit8650794391729c6fee34bc2644ccbb85bd8fd58d (patch)
treedc3abc8837ab7b4ee04069a94d429c60f9558bbd /python/mach/setup.py
parentc128c9a609349b522e7c1fd948a5eb6b4288e1d2 (diff)
parent43b38e3e370e15a82409f8dbcbf408abd7d28e8e (diff)
downloadservo-8650794391729c6fee34bc2644ccbb85bd8fd58d.tar.gz
servo-8650794391729c6fee34bc2644ccbb85bd8fd58d.zip
Auto merge of #28644 - gian-carlo-d:add-ubuntu-21.10-compatibility, r=jdm
Allow builds / tests on Ubuntu 21.10 <!-- Please describe your changes on the following line: --> This PR updates the version check in `python/servo/bootstrap.py` for Ubuntu to `> 21.10` to accommodate the latest version. It also updates the `clang-format` check in `test_commands.py` to use `find()` instead of `startswith()` to account for possible distro-specific insertions into the `clang-format --version` command. Ubuntu, for example, outputs `Ubuntu clang-format version 13.0.0-2`, which caused `version.startswith()` to throw an error as it looked for `clang-format` at the beginning of the string. This would cause `./mach test-tidy` to skip the CPP formatting portion. ![image](https://user-images.githubusercontent.com/17208534/146147849-92dd9849-5fc4-4632-b8d0-23b51dc34706.png) These two changes should help run bootstrap and test commands on the latest Ubuntu version. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors <!-- Either: --> - [X] These changes do not require tests because: I do not believe there are any current tests for the version checks (as the version checks are in-and-of themselves a test before running the bootstrap/test commands) <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Diffstat (limited to 'python/mach/setup.py')
0 files changed, 0 insertions, 0 deletions