diff options
| author | Martin Robinson <mrobinson@igalia.com> | 2024-11-19 16:36:55 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-11-19 15:36:55 +0000 |
| commit | b4643c1f11d1929c715f38cdf1bdd32559bc9fdf (patch) | |
| tree | 7f2189a0b0c4aa6ea3b3ef5d503beba8d8b74466 /components | |
| parent | 0eda2de19fd69619bf9a8ac47da34b764c3d06f8 (diff) | |
| download | servo-b4643c1f11d1929c715f38cdf1bdd32559bc9fdf.tar.gz servo-b4643c1f11d1929c715f38cdf1bdd32559bc9fdf.zip | |
script: Remove a warning about a common situation involving OOP iframes (#34288)
When an iframe is out of process or running in a different
`ScriptThread`, it is expected that their `Document`s cannot be found in
the current `ScriptThread` during the *update-the-rendering* step.
Remove the warning in that situation and add a comment instead.
Signed-off-by: Martin Robinson <mrobinson@igalia.com>
Co-authored-by: Mukilan Thiyagarajan <mukilan@igalia.com>
Diffstat (limited to 'components')
| -rw-r--r-- | components/script/script_thread.rs | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/components/script/script_thread.rs b/components/script/script_thread.rs index 0057a86d872..ff066eda0c9 100644 --- a/components/script/script_thread.rs +++ b/components/script/script_thread.rs @@ -1620,8 +1620,11 @@ impl ScriptThread { // Note: the spec reads: "for doc in docs" at each step // whereas this runs all steps per doc in docs. for pipeline_id in pipelines_to_update { + // This document is not managed by this script thread. This can happen is the pipeline is + // unexpectedly closed or simply that it is managed by a different script thread. + // TODO: It would be better if iframes knew whether or not their Document was managed + // by the same script thread. let Some(document) = self.documents.borrow().find_document(pipeline_id) else { - warn!("Updating the rendering for closed pipeline {pipeline_id}."); continue; }; // TODO(#32004): The rendering should be updated according parent and shadow root order |