diff options
author | Zbynek Winkler <zbynek.winkler@gmail.com> | 2016-04-14 21:38:45 +0200 |
---|---|---|
committer | Zbynek Winkler <zbynek.winkler@gmail.com> | 2016-04-21 08:23:03 +0200 |
commit | 7002fbedd73c4c240ea1e1593b1275b0df79c5d0 (patch) | |
tree | a09460e72f35a9c15108df1ddeb87e405ce4c28f /components | |
parent | f9608022caf7f223dfdfe960c31fb5fe7eb0d1f1 (diff) | |
download | servo-7002fbedd73c4c240ea1e1593b1275b0df79c5d0.tar.gz servo-7002fbedd73c4c240ea1e1593b1275b0df79c5d0.zip |
Ensure virtualenv activates.
There are two changes:
* remove quoting which causes virtuaenv not activate
* check virtualenv actually activated
If the quoting added in the fix in #8394 (4ff8d3ad9cea) kicks in, it
causes virtualenv to fail to activate.
For the common case it is no op:
```python
>>> from pipes import quote
>>> print quote('common/case')
common/case
```
When the path actually needs quoting, this is what happens:
```python
>>> print quote('test spaces')
'test spaces'
>>> print quote('windows\\path')
'windows\\path'
```
Note the embedded quotes.
Virtualenv in activate_this.py uses __file__ to build the path that
should be added to PATH:
```python
>>> print os.getcwd()
C:\software\git
>>> print os.path.abspath(quote('windows\\path'))
C:\software\git\'windows\path'
>>>
```
The constructed path is not valid. Adding it at the beginning of PATH
has no effect. This issue affects any case when the call to `quote`
kicks in.
Diffstat (limited to 'components')
0 files changed, 0 insertions, 0 deletions