diff options
author | bors-servo <lbergstrom+bors@mozilla.com> | 2017-08-07 20:13:32 -0500 |
---|---|---|
committer | GitHub <noreply@github.com> | 2017-08-07 20:13:32 -0500 |
commit | 689dadc75174eff892e1da9d072ee9f109ede925 (patch) | |
tree | 113c5eb07048cb81988c1ad74fe7ef04dcbc478e /components | |
parent | 10c3e2f3ac781905b43b3529253ba1bc9926d9e8 (diff) | |
parent | bdf84510f8f61c328f774351072bb4d37b9d6daa (diff) | |
download | servo-689dadc75174eff892e1da9d072ee9f109ede925.tar.gz servo-689dadc75174eff892e1da9d072ee9f109ede925.zip |
Auto merge of #18005 - hiikezoe:dont-unset-animation-only-dirty-bit, r=birtles
Don't clear animation only dirty bit during style recalc
Unless the element is in a display:none subtree.
After bug 1356141, the setup of animation-only dirty bit should have matched
to normal dirty bit's one (Though they don't match in post traversal due to
throttled animation flush). An unset_animation_only_dirty_descendants call
removed in this patch cleared dirty bits which are needed for post traversal if
there is a second animation-only traversal and if there is no need to restyle
for the second animation-only traversal.
The reftest in this patch fails without either this fix or the fix for bug
1367975.
See [Gecko bug 1384435 comment 12](https://bugzilla.mozilla.org/show_bug.cgi?id=1384435#c12)
for more detail what's going on at that time.
<!-- Please describe your changes on the following line: -->
https://bugzilla.mozilla.org/show_bug.cgi?id=1384435
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
Diffstat (limited to 'components')
-rw-r--r-- | components/style/traversal.rs | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/components/style/traversal.rs b/components/style/traversal.rs index cd90f568753..a430ad22ad7 100644 --- a/components/style/traversal.rs +++ b/components/style/traversal.rs @@ -563,9 +563,6 @@ where } else { element.has_dirty_descendants() }; - if flags.for_animation_only() { - unsafe { element.unset_animation_only_dirty_descendants(); } - } // Before examining each child individually, try to prove that our children // don't need style processing. They need processing if any of the following |