diff options
author | bors-servo <lbergstrom+bors@mozilla.com> | 2016-07-03 08:19:04 -0700 |
---|---|---|
committer | GitHub <noreply@github.com> | 2016-07-03 08:19:04 -0700 |
commit | b0a8ce5341f5148e36523fee0b0fcbc2684c0a68 (patch) | |
tree | f7c3746dbfa55e7ba5d863a921b7a89211974858 /components/webdriver_server/lib.rs | |
parent | a9c58c99fb897f95f37d893ecb3994864ef58da9 (diff) | |
parent | d9c9d4ab369c09dae378cb886b9dc7409f114c8f (diff) | |
download | servo-b0a8ce5341f5148e36523fee0b0fcbc2684c0a68.tar.gz servo-b0a8ce5341f5148e36523fee0b0fcbc2684c0a68.zip |
Auto merge of #12178 - frewsxcv:prefs, r=emilio
Refactor `util::prefs` operations to be methods on static struct.
<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).
<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because _____
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12178)
<!-- Reviewable:end -->
Diffstat (limited to 'components/webdriver_server/lib.rs')
-rw-r--r-- | components/webdriver_server/lib.rs | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/components/webdriver_server/lib.rs b/components/webdriver_server/lib.rs index d2cedb10858..7e060d74c6a 100644 --- a/components/webdriver_server/lib.rs +++ b/components/webdriver_server/lib.rs @@ -46,7 +46,7 @@ use std::sync::mpsc::Sender; use std::thread; use std::time::Duration; use url::Url; -use util::prefs::{get_pref, reset_all_prefs, reset_pref, set_pref, PrefValue}; +use util::prefs::{PREFS, PrefValue}; use util::thread::spawn_named; use uuid::Uuid; use webdriver::command::WindowSizeParameters; @@ -813,7 +813,7 @@ impl Handler { parameters: &GetPrefsParameters) -> WebDriverResult<WebDriverResponse> { let prefs = parameters.prefs .iter() - .map(|item| (item.clone(), get_pref(item).to_json())) + .map(|item| (item.clone(), PREFS.get(item).to_json())) .collect::<BTreeMap<_, _>>(); Ok(WebDriverResponse::Generic(ValueResponse::new(prefs.to_json()))) @@ -822,7 +822,7 @@ impl Handler { fn handle_set_prefs(&self, parameters: &SetPrefsParameters) -> WebDriverResult<WebDriverResponse> { for &(ref key, ref value) in parameters.prefs.iter() { - set_pref(key, value.clone()); + PREFS.set(key, value.clone()); } Ok(WebDriverResponse::Void) } @@ -830,12 +830,12 @@ impl Handler { fn handle_reset_prefs(&self, parameters: &GetPrefsParameters) -> WebDriverResult<WebDriverResponse> { let prefs = if parameters.prefs.len() == 0 { - reset_all_prefs(); + PREFS.reset_all(); BTreeMap::new() } else { parameters.prefs .iter() - .map(|item| (item.clone(), reset_pref(item).to_json())) + .map(|item| (item.clone(), PREFS.reset(item).to_json())) .collect::<BTreeMap<_, _>>() }; Ok(WebDriverResponse::Generic(ValueResponse::new(prefs.to_json()))) |