diff options
| author | Hiroyuki Ikezoe <hikezoe@mozilla.com> | 2018-11-22 04:03:06 +0000 |
|---|---|---|
| committer | Emilio Cobos Álvarez <emilio@crisal.io> | 2018-12-02 14:17:20 -0500 |
| commit | 2639916d7d53204281bd456abc44140de21a7740 (patch) | |
| tree | 628336c742468439197838cdb5d37a751d8b94a2 /components/style/rule_tree/mod.rs | |
| parent | 2ebad8de3648d4e11837ce25eed40a3fc889a56a (diff) | |
| download | servo-2639916d7d53204281bd456abc44140de21a7740.tar.gz servo-2639916d7d53204281bd456abc44140de21a7740.zip | |
style: Set the important rule change flag when a newly important rule is inserted.
Without this change an assertion checking IsInStyleRefresh() in
EffectCompositor::PostRestyleForAnimation will be hit when we call
FindAnimationsForCompositor from RestyleManager::DoProcessPendingRestyles
that will be introduced in a subsequent commit in this series.
I wrote a crash test which causes an assertion in KeyframeEffect::CanThrottle()
without the subsequent commit, but we need more work in display item stuff to
make the assertion won't happen (bug 1508466).
Differential Revision: https://phabricator.services.mozilla.com/D12368
Diffstat (limited to 'components/style/rule_tree/mod.rs')
| -rw-r--r-- | components/style/rule_tree/mod.rs | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/components/style/rule_tree/mod.rs b/components/style/rule_tree/mod.rs index fdd563d2372..a2caba6f9f7 100644 --- a/components/style/rule_tree/mod.rs +++ b/components/style/rule_tree/mod.rs @@ -453,6 +453,7 @@ impl RuleTree { StyleSource::from_declarations(pdb.clone_arc()), level, ); + *important_rules_changed = true; } } else { if pdb.read_with(level.guard(guards)).any_normal() { |