diff options
author | Ngo Iok Ui (Wu Yu Wei) <yuweiwu@pm.me> | 2024-05-24 15:13:20 +0900 |
---|---|---|
committer | GitHub <noreply@github.com> | 2024-05-24 06:13:20 +0000 |
commit | b1031d68c73544778bfc088db6242c7496b7eb57 (patch) | |
tree | 827bcd18c81a669462ebf11127ee8939af8d81f8 /components/shared/canvas | |
parent | fc08bd1aa79e1211323d91681308456778d3abc9 (diff) | |
download | servo-b1031d68c73544778bfc088db6242c7496b7eb57.tar.gz servo-b1031d68c73544778bfc088db6242c7496b7eb57.zip |
Move webgl_channel into base crate (#32339)
* Move webgl_channel into a shared crate
* Add license header
* Rename channle types and simplify module
* Move module to base
Diffstat (limited to 'components/shared/canvas')
-rw-r--r-- | components/shared/canvas/Cargo.toml | 1 | ||||
-rw-r--r-- | components/shared/canvas/lib.rs | 1 | ||||
-rw-r--r-- | components/shared/canvas/webgl.rs | 40 | ||||
-rw-r--r-- | components/shared/canvas/webgl_channel/ipc.rs | 15 | ||||
-rw-r--r-- | components/shared/canvas/webgl_channel/mod.rs | 157 | ||||
-rw-r--r-- | components/shared/canvas/webgl_channel/mpsc.rs | 62 |
6 files changed, 32 insertions, 244 deletions
diff --git a/components/shared/canvas/Cargo.toml b/components/shared/canvas/Cargo.toml index 519b19d1a17..dc8e9e510d4 100644 --- a/components/shared/canvas/Cargo.toml +++ b/components/shared/canvas/Cargo.toml @@ -15,6 +15,7 @@ webgl_backtrace = [] xr-profile = ["webxr-api/profile", "time"] [dependencies] +base = { workspace = true } crossbeam-channel = { workspace = true } euclid = { workspace = true } ipc-channel = { workspace = true } diff --git a/components/shared/canvas/lib.rs b/components/shared/canvas/lib.rs index e0c4050e7be..f1444ad1a3e 100644 --- a/components/shared/canvas/lib.rs +++ b/components/shared/canvas/lib.rs @@ -14,7 +14,6 @@ use crate::canvas::CanvasId; pub mod canvas; #[macro_use] pub mod webgl; -mod webgl_channel; pub enum ConstellationCanvasMsg { Create { diff --git a/components/shared/canvas/webgl.rs b/components/shared/canvas/webgl.rs index a3f68563308..0e22ee01b59 100644 --- a/components/shared/canvas/webgl.rs +++ b/components/shared/canvas/webgl.rs @@ -7,6 +7,12 @@ use std::fmt; use std::num::{NonZeroU32, NonZeroU64}; use std::ops::Deref; +/// Receiver type used in WebGLCommands. +pub use base::generic_channel::GenericReceiver as WebGLReceiver; +/// Sender type used in WebGLCommands. +pub use base::generic_channel::GenericSender as WebGLSender; +/// Result type for send()/recv() calls in in WebGLCommands. +pub use base::generic_channel::SendResult as WebGLSendResult; use euclid::default::{Rect, Size2D}; use ipc_channel::ipc::{IpcBytesReceiver, IpcBytesSender, IpcSharedMemory}; use malloc_size_of_derive::MallocSizeOf; @@ -20,17 +26,33 @@ use webxr_api::{ }; /// Helper function that creates a WebGL channel (WebGLSender, WebGLReceiver) to be used in WebGLCommands. -pub use crate::webgl_channel::webgl_channel; +pub fn webgl_channel<T>() -> Option<(WebGLSender<T>, WebGLReceiver<T>)> +where + T: for<'de> Deserialize<'de> + Serialize, +{ + base::generic_channel::channel(servo_config::opts::multiprocess()) +} + /// Entry point channel type used for sending WebGLMsg messages to the WebGL renderer. -pub use crate::webgl_channel::WebGLChan; +#[derive(Clone, Debug, Deserialize, Serialize)] +pub struct WebGLChan(pub WebGLSender<WebGLMsg>); + +impl WebGLChan { + #[inline] + pub fn send(&self, msg: WebGLMsg) -> WebGLSendResult { + self.0.send(msg) + } +} + /// Entry point type used in a Script Pipeline to get the WebGLChan to be used in that thread. -pub use crate::webgl_channel::WebGLPipeline; -/// Receiver type used in WebGLCommands. -pub use crate::webgl_channel::WebGLReceiver; -/// Result type for send()/recv() calls in in WebGLCommands. -pub use crate::webgl_channel::WebGLSendResult; -/// Sender type used in WebGLCommands. -pub use crate::webgl_channel::WebGLSender; +#[derive(Clone, Debug, Deserialize, Serialize)] +pub struct WebGLPipeline(pub WebGLChan); + +impl WebGLPipeline { + pub fn channel(&self) -> WebGLChan { + self.0.clone() + } +} #[derive(Clone, Debug, Deserialize, Serialize)] pub struct WebGLCommandBacktrace { diff --git a/components/shared/canvas/webgl_channel/ipc.rs b/components/shared/canvas/webgl_channel/ipc.rs deleted file mode 100644 index be320a69624..00000000000 --- a/components/shared/canvas/webgl_channel/ipc.rs +++ /dev/null @@ -1,15 +0,0 @@ -/* This Source Code Form is subject to the terms of the Mozilla Public - * License, v. 2.0. If a copy of the MPL was not distributed with this - * file, You can obtain one at https://mozilla.org/MPL/2.0/. */ - -use std::io; - -use serde::{Deserialize, Serialize}; - -pub type WebGLSender<T> = ipc_channel::ipc::IpcSender<T>; -pub type WebGLReceiver<T> = ipc_channel::ipc::IpcReceiver<T>; - -pub fn webgl_channel<T: Serialize + for<'de> Deserialize<'de>>( -) -> Result<(WebGLSender<T>, WebGLReceiver<T>), io::Error> { - ipc_channel::ipc::channel() -} diff --git a/components/shared/canvas/webgl_channel/mod.rs b/components/shared/canvas/webgl_channel/mod.rs deleted file mode 100644 index 13c66ef382d..00000000000 --- a/components/shared/canvas/webgl_channel/mod.rs +++ /dev/null @@ -1,157 +0,0 @@ -/* This Source Code Form is subject to the terms of the Mozilla Public - * License, v. 2.0. If a copy of the MPL was not distributed with this - * file, You can obtain one at https://mozilla.org/MPL/2.0/. */ - -//! Enum wrappers to be able to select different channel implementations at runtime. - -mod ipc; -mod mpsc; - -use std::fmt; - -use ipc_channel::ipc::IpcSender; -use ipc_channel::router::ROUTER; -use lazy_static::lazy_static; -use serde::{Deserialize, Serialize}; -use servo_config::opts; - -use crate::webgl::WebGLMsg; - -lazy_static! { - static ref IS_MULTIPROCESS: bool = opts::multiprocess(); -} - -#[derive(Deserialize, Serialize)] -pub enum WebGLSender<T: Serialize> { - Ipc(ipc::WebGLSender<T>), - Mpsc(mpsc::WebGLSender<T>), -} - -impl<T> Clone for WebGLSender<T> -where - T: Serialize, -{ - fn clone(&self) -> Self { - match *self { - WebGLSender::Ipc(ref chan) => WebGLSender::Ipc(chan.clone()), - WebGLSender::Mpsc(ref chan) => WebGLSender::Mpsc(chan.clone()), - } - } -} - -impl<T: Serialize> fmt::Debug for WebGLSender<T> { - fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { - write!(f, "WebGLSender(..)") - } -} - -impl<T: Serialize> WebGLSender<T> { - #[inline] - pub fn send(&self, msg: T) -> WebGLSendResult { - match *self { - WebGLSender::Ipc(ref sender) => sender.send(msg).map_err(|_| WebGLSendError), - WebGLSender::Mpsc(ref sender) => sender.send(msg).map_err(|_| WebGLSendError), - } - } -} - -#[derive(Debug)] -pub struct WebGLSendError; -pub type WebGLSendResult = Result<(), WebGLSendError>; - -#[derive(Debug)] -pub struct WebGLReceiveError; -pub type WebGLReceiveResult<T> = Result<T, WebGLReceiveError>; - -pub enum WebGLReceiver<T> -where - T: for<'de> Deserialize<'de> + Serialize, -{ - Ipc(ipc::WebGLReceiver<T>), - Mpsc(mpsc::WebGLReceiver<T>), -} - -impl<T> WebGLReceiver<T> -where - T: for<'de> Deserialize<'de> + Serialize, -{ - pub fn recv(&self) -> WebGLReceiveResult<T> { - match *self { - WebGLReceiver::Ipc(ref receiver) => receiver.recv().map_err(|_| WebGLReceiveError), - WebGLReceiver::Mpsc(ref receiver) => receiver.recv().map_err(|_| WebGLReceiveError), - } - } - - pub fn try_recv(&self) -> WebGLReceiveResult<T> { - match *self { - WebGLReceiver::Ipc(ref receiver) => receiver.try_recv().map_err(|_| WebGLReceiveError), - WebGLReceiver::Mpsc(ref receiver) => receiver.try_recv().map_err(|_| WebGLReceiveError), - } - } - - pub fn into_inner(self) -> crossbeam_channel::Receiver<T> - where - T: Send + 'static, - { - match self { - WebGLReceiver::Ipc(receiver) => { - ROUTER.route_ipc_receiver_to_new_crossbeam_receiver(receiver) - }, - WebGLReceiver::Mpsc(receiver) => receiver.into_inner(), - } - } -} - -pub fn webgl_channel<T>() -> Option<(WebGLSender<T>, WebGLReceiver<T>)> -where - T: for<'de> Deserialize<'de> + Serialize, -{ - if *IS_MULTIPROCESS { - ipc::webgl_channel() - .map(|(tx, rx)| (WebGLSender::Ipc(tx), WebGLReceiver::Ipc(rx))) - .ok() - } else { - mpsc::webgl_channel() - .map(|(tx, rx)| (WebGLSender::Mpsc(tx), WebGLReceiver::Mpsc(rx))) - .ok() - } -} - -#[derive(Clone, Debug, Deserialize, Serialize)] -pub struct WebGLChan(pub WebGLSender<WebGLMsg>); - -impl WebGLChan { - #[inline] - pub fn send(&self, msg: WebGLMsg) -> WebGLSendResult { - self.0.send(msg) - } - - pub fn to_ipc(&self) -> IpcSender<WebGLMsg> { - match self.0 { - WebGLSender::Ipc(ref sender) => sender.clone(), - WebGLSender::Mpsc(ref mpsc_sender) => { - let (sender, receiver) = - ipc_channel::ipc::channel().expect("IPC Channel creation failed"); - let mpsc_sender = mpsc_sender.clone(); - ipc_channel::router::ROUTER.add_route( - receiver.to_opaque(), - Box::new(move |message| { - if let Ok(message) = message.to() { - let _ = mpsc_sender.send(message); - } - }), - ); - sender - }, - } - } -} - -#[derive(Clone, Debug, Deserialize, Serialize)] -pub struct WebGLPipeline(pub WebGLChan); - -impl WebGLPipeline { - pub fn channel(&self) -> WebGLChan { - self.0.clone() - } -} diff --git a/components/shared/canvas/webgl_channel/mpsc.rs b/components/shared/canvas/webgl_channel/mpsc.rs deleted file mode 100644 index b7d0bfcc3da..00000000000 --- a/components/shared/canvas/webgl_channel/mpsc.rs +++ /dev/null @@ -1,62 +0,0 @@ -/* This Source Code Form is subject to the terms of the Mozilla Public - * License, v. 2.0. If a copy of the MPL was not distributed with this - * file, You can obtain one at https://mozilla.org/MPL/2.0/. */ - -use serde::{Deserialize, Deserializer, Serialize, Serializer}; - -macro_rules! unreachable_serializable { - ($name:ident) => { - impl<T> Serialize for $name<T> { - fn serialize<S: Serializer>(&self, _: S) -> Result<S::Ok, S::Error> { - unreachable!(); - } - } - - impl<'a, T> Deserialize<'a> for $name<T> { - fn deserialize<D>(_: D) -> Result<$name<T>, D::Error> - where - D: Deserializer<'a>, - { - unreachable!(); - } - } - }; -} - -pub struct WebGLSender<T>(crossbeam_channel::Sender<T>); -pub struct WebGLReceiver<T>(crossbeam_channel::Receiver<T>); - -impl<T> Clone for WebGLSender<T> { - fn clone(&self) -> Self { - WebGLSender(self.0.clone()) - } -} - -impl<T> WebGLSender<T> { - #[inline] - pub fn send(&self, data: T) -> Result<(), crossbeam_channel::SendError<T>> { - self.0.send(data) - } -} - -impl<T> WebGLReceiver<T> { - #[inline] - pub fn recv(&self) -> Result<T, crossbeam_channel::RecvError> { - self.0.recv() - } - #[inline] - pub fn try_recv(&self) -> Result<T, crossbeam_channel::TryRecvError> { - self.0.try_recv() - } - pub fn into_inner(self) -> crossbeam_channel::Receiver<T> { - self.0 - } -} - -pub fn webgl_channel<T>() -> Result<(WebGLSender<T>, WebGLReceiver<T>), ()> { - let (sender, receiver) = crossbeam_channel::unbounded(); - Ok((WebGLSender(sender), WebGLReceiver(receiver))) -} - -unreachable_serializable!(WebGLReceiver); -unreachable_serializable!(WebGLSender); |