diff options
| author | Delan Azabani <dazabani@igalia.com> | 2025-01-30 19:15:35 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2025-01-30 11:15:35 +0000 |
| commit | 5e9de2cb61fbfd82b27343bf03439838458b9848 (patch) | |
| tree | 64574624cda94237bbfc443a29b792229fde0ee2 /components/shared/base/id.rs | |
| parent | 9eeb602f7afca502753bb8211ab646c952951761 (diff) | |
| download | servo-5e9de2cb61fbfd82b27343bf03439838458b9848.tar.gz servo-5e9de2cb61fbfd82b27343bf03439838458b9848.zip | |
Include `WebViewId` into EmbedderMsg variants where possible (#35211)
`EmbedderMsg` was previously paired with an implicit
`Option<WebViewId>`, even though almost all variants were either always
`Some` or always `None`, depending on whether there was a `WebView
involved.
This patch adds the `WebViewId` to as many `EmbedderMsg` variants as
possible, so we can call their associated `WebView` delegate methods
without needing to check and unwrap the `Option`. In many cases, this
required more changes to plumb through the `WebViewId`.
Notably, all `Request`s now explicitly need a `WebView` or not, in order
to ensure that it is passed when appropriate.
Signed-off-by: Delan Azabani <dazabani@igalia.com>
Co-authored-by: Martin Robinson <mrobinson@igalia.com>
Diffstat (limited to 'components/shared/base/id.rs')
| -rw-r--r-- | components/shared/base/id.rs | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/components/shared/base/id.rs b/components/shared/base/id.rs index a20e4d20889..071d7107b9c 100644 --- a/components/shared/base/id.rs +++ b/components/shared/base/id.rs @@ -443,3 +443,5 @@ pub const TEST_BROWSING_CONTEXT_ID: BrowsingContextId = BrowsingContextId { namespace_id: TEST_NAMESPACE, index: TEST_BROWSING_CONTEXT_INDEX, }; + +pub const TEST_WEBVIEW_ID: WebViewId = TopLevelBrowsingContextId(TEST_BROWSING_CONTEXT_ID); |