diff options
| author | Josh Matthews <josh@joshmatthews.net> | 2025-04-16 02:52:48 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2025-04-16 06:52:48 +0000 |
| commit | 9aa09d73b5d82406b0d922a30f30b65ffcf9eb96 (patch) | |
| tree | 3ef51c4910d03dce588b05704cadd0537fb037b2 /components/servo/tests/common | |
| parent | f5e6eb289af2507fa01a7926eff77d46c773b2c1 (diff) | |
| download | servo-9aa09d73b5d82406b0d922a30f30b65ffcf9eb96.tar.gz servo-9aa09d73b5d82406b0d922a30f30b65ffcf9eb96.zip | |
Fix crash when setting custom property on Location (#36494)
The JS engine uses types like `Handle<Maybe<PropertyDescriptor>>` in
various places and our automated bindings are not able to handle the
Maybe type. We have hand-written bindings that use outparams to indicate
a PropertyDescriptor value is actually the Nothing type, but that data
was getting lost when we passed the property descriptor to
SetPropertyIgnoringNamedGetter, which assumed that the property
descriptor was always valid.
Depends on https://github.com/servo/mozjs/pull/579.
Testing: Manual testing on testcase from
https://github.com/servo/servo/issues/34709, and new crashtest added.
Fixes: #34709
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
Diffstat (limited to 'components/servo/tests/common')
0 files changed, 0 insertions, 0 deletions