aboutsummaryrefslogtreecommitdiffstats
path: root/components/script_traits/script_msg.rs
diff options
context:
space:
mode:
authorbors-servo <lbergstrom+bors@mozilla.com>2016-11-03 18:11:05 -0500
committerGitHub <noreply@github.com>2016-11-03 18:11:05 -0500
commitce725c9475b9fb97a8559b29c1e7a080633cd002 (patch)
treec95f5e2c07adfd29e4a9751430ed44aecf9ab53c /components/script_traits/script_msg.rs
parent74a3ea9135b13683a9e223790fe573a46cc6a141 (diff)
parentf3993d99b965cd0accb2eed77fb27dd1eb863848 (diff)
downloadservo-ce725c9475b9fb97a8559b29c1e7a080633cd002.tar.gz
servo-ce725c9475b9fb97a8559b29c1e7a080633cd002.zip
Auto merge of #13646 - asajeffrey:script-lookup-iframes-by-frameid, r=ConnorGBrewster
Script lookup iframes by frameid <!-- Please describe your changes on the following line: --> Lookup iframes by `FrameId` rather than `PipelineId`. This should make lookup much more reliable, since the frame id doesn't change. cc @ConnorGBrewster @aneeshusa --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes do not require tests because refactoring <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13646) <!-- Reviewable:end -->
Diffstat (limited to 'components/script_traits/script_msg.rs')
-rw-r--r--components/script_traits/script_msg.rs7
1 files changed, 3 insertions, 4 deletions
diff --git a/components/script_traits/script_msg.rs b/components/script_traits/script_msg.rs
index 82b7af96f81..b73be67c023 100644
--- a/components/script_traits/script_msg.rs
+++ b/components/script_traits/script_msg.rs
@@ -83,10 +83,9 @@ pub enum ScriptMsg {
/// A new load has been requested, with an option to replace the current entry once loaded
/// instead of adding a new entry.
LoadUrl(PipelineId, LoadData, bool),
- /// Dispatch a mozbrowser event to a given iframe,
- /// or to the window if no subpage id is provided.
- /// First PipelineId is for the parent, second PipelineId is for the actual pipeline.
- MozBrowserEvent(PipelineId, Option<PipelineId>, MozBrowserEvent),
+ /// Dispatch a mozbrowser event to the parent of this pipeline.
+ /// The first PipelineId is for the parent, the second is for the originating pipeline.
+ MozBrowserEvent(PipelineId, PipelineId, MozBrowserEvent),
/// HTMLIFrameElement Forward or Back traversal.
TraverseHistory(Option<PipelineId>, TraversalDirection),
/// Gets the length of the joint session history from the constellation.