diff options
| author | Josh Matthews <josh@joshmatthews.net> | 2025-04-04 02:45:08 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2025-04-04 06:45:08 +0000 |
| commit | b4079b3ff33a3f7e2b35ac3aacc4467f8da42242 (patch) | |
| tree | af6ae87af10c1383a3a3fcdb28b1d2544bc2fc45 /components/script_bindings/weakref.rs | |
| parent | 277c0b82dd4411798b461a4e3a782e7869ae5740 (diff) | |
| download | servo-b4079b3ff33a3f7e2b35ac3aacc4467f8da42242.tar.gz servo-b4079b3ff33a3f7e2b35ac3aacc4467f8da42242.zip | |
Move generated bindings to script_bindings (#36323)
This is the final step of #1799, where the majority of the generated
code for the JS bindings is now compiled as part of the script_bindings
build step. The remaining pieces in script must live there because they
refer to concrete DOM types; all code in script_bindings is generic over
the
[DomTypes](https://doc.servo.org/script/dom/bindings/codegen/DomTypes/trait.DomTypes.html)
trait.
My testing with incremental builds shows me a 12 second reduction in
build times on my 2024 M4 Macbook Pro when modifying code in the script
crate after these changes. Before this PR those changes took 20 seconds
to rebuild Servo, and now they take 8 seconds.
Testing: Existing WPT tests ensure no regressions.
Fixes: #1799
---------
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
Diffstat (limited to 'components/script_bindings/weakref.rs')
| -rw-r--r-- | components/script_bindings/weakref.rs | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/components/script_bindings/weakref.rs b/components/script_bindings/weakref.rs index 38f4f709997..2ec07e1f4af 100644 --- a/components/script_bindings/weakref.rs +++ b/components/script_bindings/weakref.rs @@ -29,7 +29,7 @@ use crate::root::DomRoot; /// stored for weak-referenceable bindings. We use slot 1 for holding it, /// this is unsafe for globals, we disallow weak-referenceable globals /// directly in codegen. -pub const DOM_WEAK_SLOT: u32 = 1; +pub(crate) const DOM_WEAK_SLOT: u32 = 1; /// A weak reference to a JS-managed DOM object. #[cfg_attr(crown, crown::unrooted_must_root_lint::allow_unrooted_interior)] |