diff options
author | bors-servo <lbergstrom+bors@mozilla.com> | 2015-11-03 15:29:17 +0530 |
---|---|---|
committer | bors-servo <lbergstrom+bors@mozilla.com> | 2015-11-03 15:29:17 +0530 |
commit | 9a800becdf7f6b3b3524d204485cb7c593b506f5 (patch) | |
tree | 3d426a0bb66e288dcca2d40267b06b72718d3522 /components/script | |
parent | 4f51710ed387baa1ad0a6e4cdb0fc5eee44093d5 (diff) | |
parent | 7fc93c0770cb55cf31cbadc3daff385f60fbbd7f (diff) | |
download | servo-9a800becdf7f6b3b3524d204485cb7c593b506f5.tar.gz servo-9a800becdf7f6b3b3524d204485cb7c593b506f5.zip |
Auto merge of #8239 - Ms2ger:ScriptReflow, r=pcwalton
Remove unused code around ScriptReflow.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8239)
<!-- Reviewable:end -->
Diffstat (limited to 'components/script')
-rw-r--r-- | components/script/dom/window.rs | 15 | ||||
-rw-r--r-- | components/script/layout_interface.rs | 4 | ||||
-rw-r--r-- | components/script/script_task.rs | 1 |
3 files changed, 1 insertions, 19 deletions
diff --git a/components/script/dom/window.rs b/components/script/dom/window.rs index d87b04cbfba..f487bc8101c 100644 --- a/components/script/dom/window.rs +++ b/components/script/dom/window.rs @@ -54,7 +54,7 @@ use profile_traits::mem; use rustc_serialize::base64::{FromBase64, STANDARD, ToBase64}; use script_task::{ScriptChan, ScriptPort, MainThreadScriptMsg}; use script_task::{SendableMainThreadScriptChan, MainThreadScriptChan, MainThreadTimerEventChan}; -use script_traits::{ConstellationControlMsg, TimerEventChan, TimerEventId, TimerEventRequest, TimerSource}; +use script_traits::{TimerEventChan, TimerEventId, TimerEventRequest, TimerSource}; use selectors::parser::PseudoElement; use std::ascii::AsciiExt; use std::borrow::ToOwned; @@ -109,8 +109,6 @@ pub struct Window { eventtarget: EventTarget, #[ignore_heap_size_of = "trait objects are hard"] script_chan: MainThreadScriptChan, - #[ignore_heap_size_of = "channels are hard"] - control_chan: Sender<ConstellationControlMsg>, console: MutNullableHeap<JS<Console>>, crypto: MutNullableHeap<JS<Crypto>>, navigator: MutNullableHeap<JS<Navigator>>, @@ -163,9 +161,6 @@ pub struct Window { /// Subpage id associated with this page, if any. parent_info: Option<(PipelineId, SubpageId)>, - /// Unique id for last reflow request; used for confirming completion reply. - last_reflow_id: Cell<u32>, - /// Global static data related to the DOM. dom_static: GlobalStaticData, @@ -901,9 +896,6 @@ impl Window { // Layout will let us know when it's done. let (join_chan, join_port) = channel(); - let last_reflow_id = &self.last_reflow_id; - last_reflow_id.set(last_reflow_id.get() + 1); - // On debug mode, print the reflow event information. if opts::get().relayout_event { debug_reflow_events(&goal, &query_type, &reason); @@ -917,9 +909,7 @@ impl Window { }, document: self.Document().r().upcast::<Node>().to_trusted_node_address(), window_size: window_size, - script_chan: self.control_chan.clone(), script_join_chan: join_chan, - id: last_reflow_id.get(), query_type: query_type, }; @@ -1212,7 +1202,6 @@ impl Window { page: Rc<Page>, script_chan: MainThreadScriptChan, image_cache_chan: ImageCacheChan, - control_chan: Sender<ConstellationControlMsg>, compositor: IpcSender<ScriptToCompositorMsg>, image_cache_task: ImageCacheTask, resource_task: Arc<ResourceTask>, @@ -1238,7 +1227,6 @@ impl Window { eventtarget: EventTarget::new_inherited(), script_chan: script_chan, image_cache_chan: image_cache_chan, - control_chan: control_chan, console: Default::default(), crypto: Default::default(), compositor: compositor, @@ -1266,7 +1254,6 @@ impl Window { constellation_chan: constellation_chan, page_clip_rect: Cell::new(MAX_RECT), fragment_name: DOMRefCell::new(None), - last_reflow_id: Cell::new(0), resize_event: Cell::new(None), next_subpage_id: Cell::new(SubpageId(0)), layout_chan: layout_chan, diff --git a/components/script/layout_interface.rs b/components/script/layout_interface.rs index acb69a02321..afc7adedbd3 100644 --- a/components/script/layout_interface.rs +++ b/components/script/layout_interface.rs @@ -175,14 +175,10 @@ pub struct ScriptReflow { pub reflow_info: Reflow, /// The document node. pub document: TrustedNodeAddress, - /// The channel through which messages can be sent back to the script task. - pub script_chan: Sender<ConstellationControlMsg>, /// The current window size. pub window_size: WindowSizeData, /// The channel that we send a notification to. pub script_join_chan: Sender<()>, - /// Unique identifier - pub id: u32, /// The type of query if any to perform during this reflow. pub query_type: ReflowQueryType, } diff --git a/components/script/script_task.rs b/components/script/script_task.rs index cd4a4a09308..f9eb6b5db31 100644 --- a/components/script/script_task.rs +++ b/components/script/script_task.rs @@ -1588,7 +1588,6 @@ impl ScriptTask { page.clone(), MainThreadScriptChan(sender.clone()), self.image_cache_channel.clone(), - self.control_chan.clone(), self.compositor.borrow_mut().clone(), self.image_cache_task.clone(), self.resource_task.clone(), |