diff options
| author | bors-servo <metajack+bors@gmail.com> | 2015-07-21 11:28:21 -0600 |
|---|---|---|
| committer | bors-servo <metajack+bors@gmail.com> | 2015-07-21 11:28:21 -0600 |
| commit | a9f12da4f8a48daa197ff8bbc2021009fe6e2711 (patch) | |
| tree | 1f7273cd7a316469a4ae57ae81f2b26efb35b0de /components/script | |
| parent | 126f5ae8f0a1041aa881b5b8d9396d0957b16036 (diff) | |
| parent | 10296e77dc79f659f0382c62bfacdd6ff0f07cdc (diff) | |
| download | servo-a9f12da4f8a48daa197ff8bbc2021009fe6e2711.tar.gz servo-a9f12da4f8a48daa197ff8bbc2021009fe6e2711.zip | |
Auto merge of #6592 - frewsxcv:notimplementederror, r=Ms2ger
Use NotImplementedError for Python base class methods
From the Python docs:
https://docs.python.org/2/library/exceptions.html#exceptions.NotImplementedError
"In user defined base classes, abstract methods should raise this
exception when they require derived classes to override the method."
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6592)
<!-- Reviewable:end -->
Diffstat (limited to 'components/script')
| -rw-r--r-- | components/script/dom/bindings/codegen/CodegenRust.py | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/components/script/dom/bindings/codegen/CodegenRust.py b/components/script/dom/bindings/codegen/CodegenRust.py index aa0c682c561..b11a7fe25c1 100644 --- a/components/script/dom/bindings/codegen/CodegenRust.py +++ b/components/script/dom/bindings/codegen/CodegenRust.py @@ -272,7 +272,7 @@ class CGThing(): def define(self): """Produce code for a Rust file.""" - assert(False) # Override me! + raise NotImplementedError # Override me! class CGNativePropertyHooks(CGThing): @@ -2134,7 +2134,7 @@ class CGAbstractMethod(CGThing): return "\n}\n" def definition_body(self): - assert(False) # Override me! + raise NotImplementedError # Override me! def CreateBindingJSObject(descriptor, parent=None): @@ -2843,7 +2843,7 @@ let global = global_object_for_js_object(JS_CALLEE(cx, vp).to_object()); return CGList([preamble, self.generate_code()]) def generate_code(self): - assert False # Override me + raise NotImplementedError # Override me! class CGSpecializedMethod(CGAbstractExternMethod): @@ -4538,8 +4538,7 @@ let this: *const %s = native_from_reflector::<%s>(obj); ]) def generate_code(self): - # Override me - assert(False) + raise NotImplementedError # Override me! def finalizeHook(descriptor, hookName, context): |