diff options
author | bors-servo <lbergstrom+bors@mozilla.com> | 2019-08-27 01:28:26 -0400 |
---|---|---|
committer | GitHub <noreply@github.com> | 2019-08-27 01:28:26 -0400 |
commit | 245ce017e3ee985b8c69de0ef3b27f91a1d75144 (patch) | |
tree | 06abb2a8a6a32cb46a5b411f7ad507c0ca1f5c21 /components/script | |
parent | dac74a18261175c230acc5d1728f0cef65e27589 (diff) | |
parent | 789cc5a2e8d2cbfb92c391b63bd76ac6256491e2 (diff) | |
download | servo-245ce017e3ee985b8c69de0ef3b27f91a1d75144.tar.gz servo-245ce017e3ee985b8c69de0ef3b27f91a1d75144.zip |
Auto merge of #24051 - TheGoddessInari:fix_windows, r=jdm
build_commands: Make Visual Studio detection not assume environment
<!-- Please describe your changes on the following line: -->
Ever since 681d7b165a849bc2c93b11b5968d345f1868a987, servo breaks building if you're not running Visual Studio 2015 or 2017 in the default location on C:.
I rewrote the PR to not assume environment, similarly to #23098.
We need to stop meeting like this. 🦊
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)
<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because 681d7b165a849bc2c93b11b5968d345f1868a987 didn't. Realistically, there should be environment tests for Visual Studio 2015, 2017, and 2019, but I won't have the time for it soon.
<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24051)
<!-- Reviewable:end -->
Diffstat (limited to 'components/script')
0 files changed, 0 insertions, 0 deletions