diff options
author | bors-servo <lbergstrom+bors@mozilla.com> | 2016-07-04 16:52:19 -0700 |
---|---|---|
committer | GitHub <noreply@github.com> | 2016-07-04 16:52:19 -0700 |
commit | e21b47c2cc14897380a8c4ef2dfa650b1dd48ab5 (patch) | |
tree | 3432e179f7edc4ec2f33e9ba3215a2e915308f7d /components/script/webdriver_handlers.rs | |
parent | 1cba3b3e9835fffbae91ab9dac76ed1f75bcf5c7 (diff) | |
parent | 664235821731c8d5eaf6d55852a9ee43b30a77f2 (diff) | |
download | servo-e21b47c2cc14897380a8c4ef2dfa650b1dd48ab5.tar.gz servo-e21b47c2cc14897380a8c4ef2dfa650b1dd48ab5.zip |
Auto merge of #12243 - TravisDean:else-brace-check, r=ConnorGBrewster
Add style check and test for else braces
<!-- Please describe your changes on the following line: -->
Added a regex check to enforce project style guidelines. Added unit check. Catches:
```
}
else {
```
when it should be
`} else {`
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors (no core files changed)
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #12234 (github issue number if applicable).
<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12243)
<!-- Reviewable:end -->
Diffstat (limited to 'components/script/webdriver_handlers.rs')
-rw-r--r-- | components/script/webdriver_handlers.rs | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/components/script/webdriver_handlers.rs b/components/script/webdriver_handlers.rs index fe19f52fafa..16395e53bc0 100644 --- a/components/script/webdriver_handlers.rs +++ b/components/script/webdriver_handlers.rs @@ -374,8 +374,7 @@ pub fn handle_is_selected(context: &BrowsingContext, } else if let Some(_) = node.downcast::<HTMLElement>() { Ok(false) // regular elements are not selectable - } - else { + } else { Err(()) } }, |