diff options
| author | bors-servo <lbergstrom+bors@mozilla.com> | 2017-09-04 11:54:15 -0500 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2017-09-04 11:54:15 -0500 |
| commit | 4608955949aa20a2d2ed251b56e9a5a3cf5681c5 (patch) | |
| tree | 0d63f5efd3ea8b49f55a30b45b32a1c8cf350212 /components/script/task_source | |
| parent | 293ffa06daa5cd2c3588833af3ed211ed3935d36 (diff) | |
| parent | b81f6b32864e080c0fc6b019d8f2584924e8f1e0 (diff) | |
| download | servo-4608955949aa20a2d2ed251b56e9a5a3cf5681c5.tar.gz servo-4608955949aa20a2d2ed251b56e9a5a3cf5681c5.zip | |
Auto merge of #18366 - emilio:fix-statistics-crash, r=bholley
style: Avoid dropping the other threads' TLS contexts too early.
When collecting style statistics, we have this path that moves the TLS contexts
to be dropped before the local context.
Since destroying the TLS context runs the sequential task queue, that means that
sequential tasks would be executed sooner than usual, before we drop the main
thread TLS context.
Since we have that reuse of the main thread context's bloom filter, and some
tasks end up creating one (Servo_StyleSet_GetBaseComputedValuesForElement, I'm
looking at you), we may borrow the bloom filter before we're done with it on the
traversal code path.
This was hitting on YouTube, when DUMP_STYLE_STATISTICS was used.
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18366)
<!-- Reviewable:end -->
Diffstat (limited to 'components/script/task_source')
0 files changed, 0 insertions, 0 deletions