diff options
author | bors-servo <lbergstrom+bors@mozilla.com> | 2019-10-18 13:00:37 -0400 |
---|---|---|
committer | GitHub <noreply@github.com> | 2019-10-18 13:00:37 -0400 |
commit | 83fb2b06d064589b12fc9f573a97ef85598f1980 (patch) | |
tree | 5e144b2f9a2acfda2a9c844c44b486b5fe8ec726 /components/script/task_source/mod.rs | |
parent | 32eb858a6a0534d8acdd5184a50a22d90c18b2a8 (diff) | |
parent | 328809aebef8ee2d9346159c365d7ae0d46db644 (diff) | |
download | servo-83fb2b06d064589b12fc9f573a97ef85598f1980.tar.gz servo-83fb2b06d064589b12fc9f573a97ef85598f1980.zip |
Auto merge of #24464 - rasviitanen:offscreen-canvas, r=jdm
fix getimagedata returns empty pixels
<!-- Please describe your changes on the following line: -->
GetImageData for OffscreenCanvas without an associated canvas element returned blank pixels. To solve this, we now pass a `Size2D` instead of a canvas to relevant functions.
I don't quite know if it's ok that `OffscreenCanvasRenderingContext2D` now have a `width` and `height`, but I found no other reasonable solution to this.
There are some tests that previously were marked as `PASS` that are now failing. It seems that they were passing for the wrong reason.
These are:
> tests/wpt/metadata/offscreen-canvas/pixel-manipulation/2d.imageData.put.unchanged.html.ini
> tests/wpt/metadata/offscreen-canvas/pixel-manipulatio/2d.imageData.put.unchanged.worker.js.ini
> tests/wpt/metadata/offscreen-canvas/the-offscreen-canvas/initial.reset.path.html.ini
> tests/wpt/metadata/offscreen-canvas/the-offscreen-canvas/initial.reset.path.worker.js.ini
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #24271 (GitHub issue number if applicable)
<!-- Either: -->
- [x] There are tests for these changes
<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Diffstat (limited to 'components/script/task_source/mod.rs')
0 files changed, 0 insertions, 0 deletions