diff options
author | bors-servo <lbergstrom+bors@mozilla.com> | 2018-09-14 06:56:07 -0400 |
---|---|---|
committer | GitHub <noreply@github.com> | 2018-09-14 06:56:07 -0400 |
commit | 0a2c61da91e77102ae774075ec4126937a79f038 (patch) | |
tree | 02d915b4d1c1462b42d73abcc63174e47e77204a /components/script/task_source/dom_manipulation.rs | |
parent | 170e232606c7d2c4834c540aa8a0d6f2f7856a55 (diff) | |
parent | 68b6bbd35f3b664263b61cbb00ddaf141ebc7ef4 (diff) | |
download | servo-0a2c61da91e77102ae774075ec4126937a79f038.tar.gz servo-0a2c61da91e77102ae774075ec4126937a79f038.zip |
Auto merge of #21710 - mandreyel:load-url-privacy-mode-preservation, r=paulrouget
Fix private browsing mode preservation when loading URL
`Constellation::load_url` disregards the existing `BrowsingContext`'s `is_private` field when loading a new URL and creating a new `Pipeline` for the page load, which means that the `Pipeline` is always passed the public resource thread, even if its browsing context is in private browsing mode. This PR fixes that.
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #21706 (github issue number if applicable).
<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___
- [x] I'm not actually sure. I haven't found tests related to private browsing so maybe that's why this bug wasn't caught earlier?
<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21710)
<!-- Reviewable:end -->
Diffstat (limited to 'components/script/task_source/dom_manipulation.rs')
0 files changed, 0 insertions, 0 deletions