diff options
| author | bors-servo <lbergstrom+bors@mozilla.com> | 2018-07-09 22:00:25 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2018-07-09 22:00:25 -0400 |
| commit | 2bc70e738b01051a64f2183691e0abd9a0f84072 (patch) | |
| tree | 598365a0ba8bec28b89b15aef0bb4eabd61f5d86 /components/script/stylesheet_loader.rs | |
| parent | 82213cce6f3a4e14a007f1e584d69bfd6611d4e0 (diff) | |
| parent | c7871811c8a14b9233f9cce61ac9f06bf76423ed (diff) | |
| download | servo-2bc70e738b01051a64f2183691e0abd9a0f84072.tar.gz servo-2bc70e738b01051a64f2183691e0abd9a0f84072.zip | |
Auto merge of #21139 - kleinph:move-float-clear-outside-mako, r=emilio
style: Move `float` CSS property outside mako
Hi, I am fairly new to Rust and this is my first contribution to a Rust project.
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #21130
<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____
I'm not sure if the approach with the two enums is good. Please let me know if this can be improved.
Regarding the tests I'm unsure: `tests/wpt/web-platform-tests/css/css-display/display-contents-float-001.html` seems to fail already before this PR, (and the cause is maybe not related to the style property definition).
Also I would like to add some docs, is it allowed to use the descriptions from MDN (https://developer.mozilla.org/en-US/docs/Web/CSS/float).
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21139)
<!-- Reviewable:end -->
Diffstat (limited to 'components/script/stylesheet_loader.rs')
0 files changed, 0 insertions, 0 deletions