diff options
author | bors-servo <lbergstrom+bors@mozilla.com> | 2019-11-14 06:51:33 -0500 |
---|---|---|
committer | GitHub <noreply@github.com> | 2019-11-14 06:51:33 -0500 |
commit | f3b1f0d30858e65811f436c7f941d374977dc6ff (patch) | |
tree | 0227353c00008232651ee05d9cfad7c8947c59a9 /components/script/script_thread.rs | |
parent | f65cb94b9e417bdaab6fd8d699bf213ae55cd740 (diff) | |
parent | b30fc2d19ea672e2c7f50d198b29838544b7c000 (diff) | |
download | servo-f3b1f0d30858e65811f436c7f941d374977dc6ff.tar.gz servo-f3b1f0d30858e65811f436c7f941d374977dc6ff.zip |
Auto merge of #24624 - garasubo:fix-keypress-trigger, r=paulrouget
Fix keypress trigger condition
Fix #22346
keypress event should be triggered for keys representing character
values. So, we should trigger this event for enter key.
This event should not trigger for IME inputs.
TODO:
- It seems we don't handle composition events correctly. To implement this keypress condition correctly, we should fix that first. In my current implementation, onkeypress event will be trigger when the user press Enter key to send inputs in IME (onCompotionEnd).
- I don't update any tests, and I couldn't find any tests related to this change in WPT. It might be better to add some tests for it, but I don't know what is the appropriate way.
<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #___ (GitHub issue number if applicable)
<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___
<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Diffstat (limited to 'components/script/script_thread.rs')
0 files changed, 0 insertions, 0 deletions