diff options
author | Martin Robinson <mrobinson@igalia.com> | 2025-01-01 14:50:52 +0100 |
---|---|---|
committer | GitHub <noreply@github.com> | 2025-01-01 13:50:52 +0000 |
commit | 77cfca65c441ff1f8b54a507c9802e7ae6893e62 (patch) | |
tree | a7d141eb43f22a94ba6f4a548e0346e9358d49c5 /components/script/messaging.rs | |
parent | deb819f23368ed43b9312a439e48f9d5f961930c (diff) | |
download | servo-77cfca65c441ff1f8b54a507c9802e7ae6893e62.tar.gz servo-77cfca65c441ff1f8b54a507c9802e7ae6893e62.zip |
script: Eliminate code duplication in the task queue (#34798)
Instead of creating a type for each `TaskSource` variety have each `TaskSource`
hold the same kind of sender (this was inconsistent before, but each
sender was effectively the same trait object), a pipeline, and a
`TaskSourceName`. This elminates the need to reimplement the same
queuing code for every task source.
In addition, have workers hold their own `TaskManager`. This allows just
exposing the manager on the `GlobalScope`. Currently the `TaskCanceller`
is different, but this will also be eliminated in a followup change.
This is a the first step toward having a shared set of `Sender`s on
`GlobalScope`.
Signed-off-by: Martin Robinson <mrobinson@igalia.com>
Diffstat (limited to 'components/script/messaging.rs')
-rw-r--r-- | components/script/messaging.rs | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/components/script/messaging.rs b/components/script/messaging.rs index 76bd536b18c..af768222fd6 100644 --- a/components/script/messaging.rs +++ b/components/script/messaging.rs @@ -235,7 +235,7 @@ impl ScriptChan for SendableMainThreadScriptChan { self.0.send(msg).map_err(|_| ()) } - fn as_boxed(&self) -> Box<dyn ScriptChan + Send> { + fn as_boxed(&self) -> Box<dyn ScriptChan> { Box::new(SendableMainThreadScriptChan((self.0).clone())) } } @@ -251,7 +251,7 @@ impl ScriptChan for MainThreadScriptChan { .map_err(|_| ()) } - fn as_boxed(&self) -> Box<dyn ScriptChan + Send> { + fn as_boxed(&self) -> Box<dyn ScriptChan> { Box::new(MainThreadScriptChan((self.0).clone())) } } |