diff options
author | bors-servo <metajack+bors@gmail.com> | 2015-08-30 20:07:40 -0600 |
---|---|---|
committer | bors-servo <metajack+bors@gmail.com> | 2015-08-30 20:07:40 -0600 |
commit | 7dda183022f9bee8b4bdffe8b4cf31e09b885d94 (patch) | |
tree | 564a197ef2a6c69ece383a66ea86d66533b5ccfb /components/script/lib.rs | |
parent | 9b2aa095f2490aeb2ac47967244df3219dfae3bb (diff) | |
parent | 43e0c4ac897cb16e1f0faaa600f713d43445d3b0 (diff) | |
download | servo-7dda183022f9bee8b4bdffe8b4cf31e09b885d94.tar.gz servo-7dda183022f9bee8b4bdffe8b4cf31e09b885d94.zip |
Auto merge of #7139 - samfoo:testable-net-load, r=jdm
Testable net load...
*The goal of this PR is to get early feedback on this before I go too far down the rabbit hole. This new code path is working, and there's several tests I've written as a proof of concept. There are still some regressions that I'll be fixing in the coming days.*
I've abstracted out the request/response cycle so that it's no longer dependent on the Hyper request/response structs. Since request/response @ hyper are structs, not traits, it made mocking them for tests impossible.
Current issues/concerns:
* This relies on boxing the `HttpResponse` that gets returned from the `HttpRequester` because `HttpResponse` is unsized. I don't know if there's a more idiomatic rust-y way of doing this?
* This relies on boxing the `Read` that is now returned from `load` for the same reason.
* The devtools and resource manager channels are still passed into `load`. It might be easier to inject these as trait dependencies instead of chans as well?
* Needs more tests.
:tophat:
#6727
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7139)
<!-- Reviewable:end -->
Diffstat (limited to 'components/script/lib.rs')
0 files changed, 0 insertions, 0 deletions