diff options
author | bors-servo <infra@servo.org> | 2023-05-05 08:18:48 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2023-05-05 08:18:48 +0200 |
commit | 121b2c987108aa7ccb5e2b3d1997b0d4d4c81d82 (patch) | |
tree | 4b93a5172ffc5f8783b1e3e8a53654c484591202 /components/script/lib.rs | |
parent | 4e37d07ea4f2bba124f78f17873fbb02c66d1cdb (diff) | |
parent | 932dc72402905cf9597b864199fd85fdb491c287 (diff) | |
download | servo-121b2c987108aa7ccb5e2b3d1997b0d4d4c81d82.tar.gz servo-121b2c987108aa7ccb5e2b3d1997b0d4d4c81d82.zip |
Auto merge of #29707 - mrobinson:fix-assertion-failure, r=mukilan
Fix an assertion failure in Layout 2020
The recent changes to containing blocks, exposed an issue in the StyleExt trait:
- When deciding whether an element creates a reference frame, whether or not it is a non-replaced inline is taken into account when determining if it has a transform.
- When deciding whether an element creates a stacking context for all descendants, whether or not it is a non-replaced inline is *not* taken into account when determining if it has a transform.
In both cases, elements that are inline should not be considered to have transforms. This commit fixes that issue as well as making it so that inlines cannot be transformed. Note that is also breaks transforms on replaced elements, but that functionality was fairly half-baked due to the inconsistent determination of transforms.
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] There are tests for these changes
<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Diffstat (limited to 'components/script/lib.rs')
0 files changed, 0 insertions, 0 deletions