diff options
| author | bors-servo <lbergstrom+bors@mozilla.com> | 2017-10-20 20:28:03 -0500 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2017-10-20 20:28:03 -0500 |
| commit | a71470abe5b8b4b5c14183c6e8bf7e4eefd5c5a7 (patch) | |
| tree | 62abd6dcf8c122efc244b7fde3419505c7aaf990 /components/script/layout_image.rs | |
| parent | ba9af5c124935734437b9258c3bdb5fee1e487a0 (diff) | |
| parent | c075372739004ac8f9452755f060e2b8919ae61f (diff) | |
| download | servo-a71470abe5b8b4b5c14183c6e8bf7e4eefd5c5a7.tar.gz servo-a71470abe5b8b4b5c14183c6e8bf7e4eefd5c5a7.zip | |
Auto merge of #18952 - jdm:no-leak-on-shutdown, r=nox
Do not trace Rust values when thread is shutting down.
This addresses a paint point when using debug-mozjs builds. jonco says that it is considered a leak when objects stored in side tables in a SpiderMonkey embedding are traced right before shutting down. This PR adds a per-thread flag that controls whether to run the Rust-side trace hooks, which is automatically toggled before the final GC occurs when destroying a JS runtime.
---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #18948 and fix #18947.
- [x] These changes do not require tests because we don't use debug-mozjs on CI
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18952)
<!-- Reviewable:end -->
Diffstat (limited to 'components/script/layout_image.rs')
0 files changed, 0 insertions, 0 deletions