aboutsummaryrefslogtreecommitdiffstats
path: root/components/script/dom
diff options
context:
space:
mode:
authorbors-servo <lbergstrom+bors@mozilla.com>2015-11-08 10:18:16 +0530
committerbors-servo <lbergstrom+bors@mozilla.com>2015-11-08 10:18:16 +0530
commitf1565bdd82bdf9a7fc383d20fdb53d07adec55c1 (patch)
treec2611b0caa345de242a143afca8fcae19b877ac1 /components/script/dom
parentabf2dfea05dfb304af5424a7c51440a14865a169 (diff)
parent4adf502846bbbce947afa7cb94bbd80ba003eedb (diff)
downloadservo-f1565bdd82bdf9a7fc383d20fdb53d07adec55c1.tar.gz
servo-f1565bdd82bdf9a7fc383d20fdb53d07adec55c1.zip
Auto merge of #8400 - sylvesterwillis:arrow-key-scroll-on-input, r=jdm
Added call to event.PreventDefault on html text inputs and textareas. This change should prevent page scrolling when up/down buttons are pressed within text inputs and textboxes which should resolve issue #8379. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8400) <!-- Reviewable:end -->
Diffstat (limited to 'components/script/dom')
-rw-r--r--components/script/dom/htmlinputelement.rs1
-rw-r--r--components/script/dom/htmltextareaelement.rs2
2 files changed, 3 insertions, 0 deletions
diff --git a/components/script/dom/htmlinputelement.rs b/components/script/dom/htmlinputelement.rs
index ed409907b42..ff4492a5520 100644
--- a/components/script/dom/htmlinputelement.rs
+++ b/components/script/dom/htmlinputelement.rs
@@ -656,6 +656,7 @@ impl VirtualMethods for HTMLInputElement {
}
RedrawSelection => {
self.force_relayout();
+ event.PreventDefault();
}
Nothing => (),
}
diff --git a/components/script/dom/htmltextareaelement.rs b/components/script/dom/htmltextareaelement.rs
index f9735e76c15..9b3f50bf91e 100644
--- a/components/script/dom/htmltextareaelement.rs
+++ b/components/script/dom/htmltextareaelement.rs
@@ -352,9 +352,11 @@ impl VirtualMethods for HTMLTextAreaElement {
}
self.force_relayout();
+ event.PreventDefault();
}
KeyReaction::RedrawSelection => {
self.force_relayout();
+ event.PreventDefault();
}
KeyReaction::Nothing => (),
}