aboutsummaryrefslogtreecommitdiffstats
path: root/components/script/dom
diff options
context:
space:
mode:
authorbors-servo <lbergstrom+bors@mozilla.com>2016-10-14 14:07:12 -0500
committerGitHub <noreply@github.com>2016-10-14 14:07:12 -0500
commit697e1979855426e4efee7e949d7b7804a9d67d0a (patch)
treef8559f6d6c273c420449243c284ec0e7f4f1ebdb /components/script/dom
parent8957b1fdc8116d0cb3b31d55f1fb918cebd12eb3 (diff)
parent0074d2a7a8b3bc40f96238347e021670528165a8 (diff)
downloadservo-697e1979855426e4efee7e949d7b7804a9d67d0a.tar.gz
servo-697e1979855426e4efee7e949d7b7804a9d67d0a.zip
Auto merge of #13703 - Rafagd:my_changes, r=Ms2ger
Replacing Node.rootNode for Node.getRootNode. - Changed the specification for the Node element to reflect the new standard. - Changed the implementation of the NodeMethod. I'm still waiting for some answers for the questions I've posted on #13699, but I'm already doing the pull request so I can get some feedback as well. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #13699 (github issue number if applicable). <!-- Either: --> - [x] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13703) <!-- Reviewable:end -->
Diffstat (limited to 'components/script/dom')
-rw-r--r--components/script/dom/node.rs5
-rw-r--r--components/script/dom/webidls/Node.webidl4
2 files changed, 6 insertions, 3 deletions
diff --git a/components/script/dom/node.rs b/components/script/dom/node.rs
index d8e14aff343..c9275306e53 100644
--- a/components/script/dom/node.rs
+++ b/components/script/dom/node.rs
@@ -1935,8 +1935,8 @@ impl NodeMethods for Node {
}
}
- // https://dom.spec.whatwg.org/#dom-node-rootnode
- fn RootNode(&self) -> Root<Node> {
+ // https://dom.spec.whatwg.org/#dom-node-getrootnode
+ fn GetRootNode(&self) -> Root<Node> {
self.inclusive_ancestors().last().unwrap()
}
@@ -2704,3 +2704,4 @@ impl Into<LayoutElementType> for ElementTypeId {
}
}
}
+
diff --git a/components/script/dom/webidls/Node.webidl b/components/script/dom/webidls/Node.webidl
index 94532e8e93a..7dcd49286d5 100644
--- a/components/script/dom/webidls/Node.webidl
+++ b/components/script/dom/webidls/Node.webidl
@@ -30,8 +30,10 @@ interface Node : EventTarget {
[Pure]
readonly attribute Document? ownerDocument;
+
[Pure]
- readonly attribute Node rootNode;
+ Node getRootNode();
+
[Pure]
readonly attribute Node? parentNode;
[Pure]