aboutsummaryrefslogtreecommitdiffstats
path: root/components/script/dom
diff options
context:
space:
mode:
authorJeremy Chen <jeremychen@mozilla.com>2017-09-11 16:04:12 +0800
committerJeremy Chen <jeremychen@mozilla.com>2017-09-21 15:30:18 +0800
commit21148c7e5183f0799745d67bfadf860c442baf3d (patch)
tree985f00c7c67c0a2d7f301dae507a8387a6dcea50 /components/script/dom
parent5afb1b7dd280b988c6d4bb302d6b9ef77d79de35 (diff)
downloadservo-21148c7e5183f0799745d67bfadf860c442baf3d.tar.gz
servo-21148c7e5183f0799745d67bfadf860c442baf3d.zip
stylo: do not handle the fallback discrete animation inside the Animate trait.
At present, we do the fallback discrete animation for non-invertible matrices in ComputedMatrix.animate(). However, according to the spec, we should fallback to discrete animation for cases like: 1. animation between transform with single non-invertible matrix 2. animation between transform with matched transform functions that have at least one non-invertible matrix 2. animation between transform with mismatched transform functions that have at least one non-invertible matrix. The current implementation only handles the first case. Moreover, we already have fallback discrete animation procedures in CSS Animation and Web Animation, so we should be able to not doing any fallback inside the Animate trait. In this patch, we let the animation between non-invertible matrices to return Err(). So, we can propagate the Err() to the callers, and let the fallback discrete animation procedure stay at the Servo_MatrixTransform_Operate, which is ouside the Animate trait.
Diffstat (limited to 'components/script/dom')
0 files changed, 0 insertions, 0 deletions