aboutsummaryrefslogtreecommitdiffstats
path: root/components/script/dom
diff options
context:
space:
mode:
authorbors-servo <lbergstrom+bors@mozilla.com>2016-07-08 09:56:31 -0700
committerGitHub <noreply@github.com>2016-07-08 09:56:31 -0700
commit12260b24d0e97ee33116d4b730203e5a2619a499 (patch)
tree15f0d085dfa1d6745885860f183607d6cb49a330 /components/script/dom
parentd475a277eebaa7d91d1b070b169e205b4c533c4f (diff)
parent55267560ca20b8e1ae1bb9173050611779673061 (diff)
downloadservo-12260b24d0e97ee33116d4b730203e5a2619a499.tar.gz
servo-12260b24d0e97ee33116d4b730203e5a2619a499.zip
Auto merge of #12277 - ConnorGBrewster:network_listener_cancellable, r=Manishearth
Make network listener runnable cancellable <!-- Please describe your changes on the following line: --> This keeps scripts from executing after its script thread has been shut down. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [x] These changes fix (maybe) #12048 (github issue number if applicable). <!-- Either: --> - [X] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12277) <!-- Reviewable:end -->
Diffstat (limited to 'components/script/dom')
-rw-r--r--components/script/dom/htmllinkelement.rs1
-rw-r--r--components/script/dom/htmlmediaelement.rs4
-rw-r--r--components/script/dom/htmlscriptelement.rs1
-rw-r--r--components/script/dom/window.rs2
-rw-r--r--components/script/dom/xmlhttprequest.rs1
5 files changed, 7 insertions, 2 deletions
diff --git a/components/script/dom/htmllinkelement.rs b/components/script/dom/htmllinkelement.rs
index ed6754afde6..ea5c25d8d46 100644
--- a/components/script/dom/htmllinkelement.rs
+++ b/components/script/dom/htmllinkelement.rs
@@ -226,6 +226,7 @@ impl HTMLLinkElement {
let listener = NetworkListener {
context: context,
script_chan: document.window().networking_task_source(),
+ wrapper: Some(document.window().get_runnable_wrapper()),
};
let response_target = AsyncResponseTarget {
sender: action_sender,
diff --git a/components/script/dom/htmlmediaelement.rs b/components/script/dom/htmlmediaelement.rs
index 7cfe19ba789..877a98311c4 100644
--- a/components/script/dom/htmlmediaelement.rs
+++ b/components/script/dom/htmlmediaelement.rs
@@ -473,10 +473,12 @@ impl HTMLMediaElement {
// 4.2
let context = Arc::new(Mutex::new(HTMLMediaElementContext::new(self, url.clone())));
let (action_sender, action_receiver) = ipc::channel().unwrap();
- let script_chan = window_from_node(self).networking_task_source();
+ let window = window_from_node(self);
+ let script_chan = window.networking_task_source();
let listener = box NetworkListener {
context: context,
script_chan: script_chan,
+ wrapper: Some(window.get_runnable_wrapper()),
};
let response_target = AsyncResponseTarget {
diff --git a/components/script/dom/htmlscriptelement.rs b/components/script/dom/htmlscriptelement.rs
index e4ce7fb068f..2d10e5f43d8 100644
--- a/components/script/dom/htmlscriptelement.rs
+++ b/components/script/dom/htmlscriptelement.rs
@@ -308,6 +308,7 @@ impl HTMLScriptElement {
let listener = NetworkListener {
context: context,
script_chan: doc.window().networking_task_source(),
+ wrapper: Some(doc.window().get_runnable_wrapper()),
};
let response_target = AsyncResponseTarget {
sender: action_sender,
diff --git a/components/script/dom/window.rs b/components/script/dom/window.rs
index 3420244a20e..9401eae5a46 100644
--- a/components/script/dom/window.rs
+++ b/components/script/dom/window.rs
@@ -949,7 +949,7 @@ impl Window {
self.current_state.set(WindowState::Zombie);
*self.js_runtime.borrow_mut() = None;
self.browsing_context.set(None);
- self.ignore_further_async_events.store(true, Ordering::Relaxed);
+ self.ignore_further_async_events.store(true, Ordering::SeqCst);
}
/// https://drafts.csswg.org/cssom-view/#dom-window-scroll
diff --git a/components/script/dom/xmlhttprequest.rs b/components/script/dom/xmlhttprequest.rs
index e76bbd0c7b3..148a51c8c6b 100644
--- a/components/script/dom/xmlhttprequest.rs
+++ b/components/script/dom/xmlhttprequest.rs
@@ -258,6 +258,7 @@ impl XMLHttpRequest {
let listener = NetworkListener {
context: context,
script_chan: script_chan,
+ wrapper: None,
};
ROUTER.add_route(action_receiver.to_opaque(), box move |message| {
listener.notify_fetch(message.to().unwrap());