diff options
author | bors-servo <lbergstrom+bors@mozilla.com> | 2019-12-05 01:49:58 -0500 |
---|---|---|
committer | GitHub <noreply@github.com> | 2019-12-05 01:49:58 -0500 |
commit | 05922c380ce5fe32a24943724ce712db5f8e00fc (patch) | |
tree | ef442980c950bea18238483f5eae85d99487f3b2 /components/script/dom | |
parent | 64bcce23898891cfdfe6a8b3baa3728aa2f12f27 (diff) | |
parent | deae103042a14db2f62aff418fe08221a6a093ec (diff) | |
download | servo-05922c380ce5fe32a24943724ce712db5f8e00fc.tar.gz servo-05922c380ce5fe32a24943724ce712db5f8e00fc.zip |
Auto merge of #25087 - bblanke:OffscreenCanvasasCanvasImageSoure, r=jdm
Support OffscreenCanvas as CanvasImageSource
Added methods to canvas_data to support drawing an offscreen canvas onto another canvas
Bug fix: Swapped OffscreenCanvas width and height parameters to match Mozilla spec
Tests: Updated metadata for 866 tests
<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #24269 (GitHub issue number if applicable)
<!-- Either: -->
- [x] These changes do not require tests because they are covered by existing tests
<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Diffstat (limited to 'components/script/dom')
-rw-r--r-- | components/script/dom/offscreencanvas.rs | 51 | ||||
-rw-r--r-- | components/script/dom/offscreencanvasrenderingcontext2d.rs | 18 | ||||
-rw-r--r-- | components/script/dom/webidls/CanvasRenderingContext2D.webidl | 2 |
3 files changed, 63 insertions, 8 deletions
diff --git a/components/script/dom/offscreencanvas.rs b/components/script/dom/offscreencanvas.rs index 2186ba54bc8..6d7cafed6f6 100644 --- a/components/script/dom/offscreencanvas.rs +++ b/components/script/dom/offscreencanvas.rs @@ -16,9 +16,12 @@ use crate::dom::globalscope::GlobalScope; use crate::dom::htmlcanvaselement::HTMLCanvasElement; use crate::dom::offscreencanvasrenderingcontext2d::OffscreenCanvasRenderingContext2D; use crate::script_runtime::JSContext; +use canvas_traits::canvas::{CanvasMsg, FromScriptMsg}; use dom_struct::dom_struct; use euclid::default::Size2D; +use ipc_channel::ipc::IpcSharedMemory; use js::rust::HandleValue; +use profile_traits::ipc; use ref_filter_map; use std::cell::Cell; use std::cell::Ref; @@ -34,22 +37,22 @@ pub enum OffscreenCanvasContext { #[dom_struct] pub struct OffscreenCanvas { eventtarget: EventTarget, - height: Cell<u64>, width: Cell<u64>, + height: Cell<u64>, context: DomRefCell<Option<OffscreenCanvasContext>>, placeholder: Option<Dom<HTMLCanvasElement>>, } impl OffscreenCanvas { pub fn new_inherited( - height: u64, width: u64, + height: u64, placeholder: Option<&HTMLCanvasElement>, ) -> OffscreenCanvas { OffscreenCanvas { eventtarget: EventTarget::new_inherited(), - height: Cell::new(height), width: Cell::new(width), + height: Cell::new(height), context: DomRefCell::new(None), placeholder: placeholder.map(Dom::from_ref), } @@ -57,12 +60,12 @@ impl OffscreenCanvas { pub fn new( global: &GlobalScope, - height: u64, width: u64, + height: u64, placeholder: Option<&HTMLCanvasElement>, ) -> DomRoot<OffscreenCanvas> { reflect_dom_object( - Box::new(OffscreenCanvas::new_inherited(height, width, placeholder)), + Box::new(OffscreenCanvas::new_inherited(width, height, placeholder)), global, OffscreenCanvasWrap, ) @@ -70,10 +73,10 @@ impl OffscreenCanvas { pub fn Constructor( global: &GlobalScope, - height: u64, width: u64, + height: u64, ) -> Fallible<DomRoot<OffscreenCanvas>> { - let offscreencanvas = OffscreenCanvas::new(global, height, width, None); + let offscreencanvas = OffscreenCanvas::new(global, width, height, None); Ok(offscreencanvas) } @@ -81,10 +84,44 @@ impl OffscreenCanvas { Size2D::new(self.Width(), self.Height()) } + pub fn origin_is_clean(&self) -> bool { + match *self.context.borrow() { + Some(OffscreenCanvasContext::OffscreenContext2d(ref context)) => { + context.origin_is_clean() + }, + _ => true, + } + } + pub fn context(&self) -> Option<Ref<OffscreenCanvasContext>> { ref_filter_map::ref_filter_map(self.context.borrow(), |ctx| ctx.as_ref()) } + pub fn fetch_all_data(&self) -> Option<(Option<IpcSharedMemory>, Size2D<u32>)> { + let size = self.get_size(); + + if size.width == 0 || size.height == 0 { + return None; + } + + let data = match self.context.borrow().as_ref() { + Some(&OffscreenCanvasContext::OffscreenContext2d(ref context)) => { + let (sender, receiver) = + ipc::channel(self.global().time_profiler_chan().clone()).unwrap(); + let msg = CanvasMsg::FromScript( + FromScriptMsg::SendPixels(sender), + context.get_canvas_id(), + ); + context.get_ipc_renderer().send(msg).unwrap(); + + Some(receiver.recv().unwrap()) + }, + None => None, + }; + + Some((data, size.to_u32())) + } + #[allow(unsafe_code)] fn get_or_init_2d_context(&self) -> Option<DomRoot<OffscreenCanvasRenderingContext2D>> { if let Some(ctx) = self.context() { diff --git a/components/script/dom/offscreencanvasrenderingcontext2d.rs b/components/script/dom/offscreencanvasrenderingcontext2d.rs index 077752d9d6e..277b5925f27 100644 --- a/components/script/dom/offscreencanvasrenderingcontext2d.rs +++ b/components/script/dom/offscreencanvasrenderingcontext2d.rs @@ -24,8 +24,10 @@ use crate::dom::htmlcanvaselement::HTMLCanvasElement; use crate::dom::imagedata::ImageData; use crate::dom::offscreencanvas::OffscreenCanvas; use crate::dom::textmetrics::TextMetrics; +use canvas_traits::canvas::{Canvas2dMsg, CanvasId, CanvasMsg}; use dom_struct::dom_struct; use euclid::default::Size2D; +use ipc_channel::ipc::IpcSender; #[dom_struct] pub struct OffscreenCanvasRenderingContext2D { @@ -72,6 +74,22 @@ impl OffscreenCanvasRenderingContext2D { pub fn set_canvas_bitmap_dimensions(&self, size: Size2D<u64>) { self.canvas_state.borrow().set_bitmap_dimensions(size); } + + pub fn send_canvas_2d_msg(&self, msg: Canvas2dMsg) { + self.canvas_state.borrow().send_canvas_2d_msg(msg) + } + + pub fn origin_is_clean(&self) -> bool { + self.canvas_state.borrow().origin_is_clean() + } + + pub fn get_canvas_id(&self) -> CanvasId { + self.canvas_state.borrow().get_canvas_id() + } + + pub fn get_ipc_renderer(&self) -> IpcSender<CanvasMsg> { + self.canvas_state.borrow().get_ipc_renderer().clone() + } } impl OffscreenCanvasRenderingContext2DMethods for OffscreenCanvasRenderingContext2D { diff --git a/components/script/dom/webidls/CanvasRenderingContext2D.webidl b/components/script/dom/webidls/CanvasRenderingContext2D.webidl index 743661cdf53..52e532e3a8b 100644 --- a/components/script/dom/webidls/CanvasRenderingContext2D.webidl +++ b/components/script/dom/webidls/CanvasRenderingContext2D.webidl @@ -12,7 +12,7 @@ typedef (HTMLOrSVGImageElement or /*HTMLVideoElement or*/ HTMLCanvasElement or /*ImageBitmap or*/ - /*OffscreenCanvas or*/ + OffscreenCanvas or /*CSSImageValue*/ CSSStyleValue) CanvasImageSource; enum CanvasFillRule { "nonzero", "evenodd" }; |