aboutsummaryrefslogtreecommitdiffstats
path: root/components/script/dom
diff options
context:
space:
mode:
authorbors-servo <lbergstrom+bors@mozilla.com>2015-11-11 21:43:21 +0530
committerbors-servo <lbergstrom+bors@mozilla.com>2015-11-11 21:43:21 +0530
commit01ff78b438fe905b02735762d696408b4d073e90 (patch)
tree5439fa4f2776b3d56f982e0f91252ab214ad1646 /components/script/dom
parent75e01de627376d987cff8bc87b5f23c79e5f36af (diff)
parent261ce49423e04daa77785b462f2facb529db842a (diff)
downloadservo-01ff78b438fe905b02735762d696408b4d073e90.tar.gz
servo-01ff78b438fe905b02735762d696408b4d073e90.zip
Auto merge of #8466 - frewsxcv:node-value, r=nox
Simplify script::dom::node NodeValue implementations <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8466) <!-- Reviewable:end -->
Diffstat (limited to 'components/script/dom')
-rw-r--r--components/script/dom/node.rs17
1 files changed, 3 insertions, 14 deletions
diff --git a/components/script/dom/node.rs b/components/script/dom/node.rs
index b1c58dcaeab..ca5b14b192c 100644
--- a/components/script/dom/node.rs
+++ b/components/script/dom/node.rs
@@ -1887,24 +1887,13 @@ impl NodeMethods for Node {
// https://dom.spec.whatwg.org/#dom-node-nodevalue
fn GetNodeValue(&self) -> Option<DOMString> {
- match self.type_id() {
- NodeTypeId::CharacterData(..) => {
- let chardata = self.downcast::<CharacterData>().unwrap();
- Some(chardata.Data())
- }
- _ => {
- None
- }
- }
+ self.downcast::<CharacterData>().map(CharacterData::Data)
}
// https://dom.spec.whatwg.org/#dom-node-nodevalue
fn SetNodeValue(&self, val: Option<DOMString>) {
- match self.type_id() {
- NodeTypeId::CharacterData(..) => {
- self.SetTextContent(val)
- }
- _ => {}
+ if let Some(character_data) = self.downcast::<CharacterData>() {
+ character_data.SetData(val.unwrap_or(DOMString::new()));
}
}