diff options
| author | Josh Matthews <josh@joshmatthews.net> | 2024-11-05 03:29:08 -0500 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-11-05 08:29:08 +0000 |
| commit | 25a0764a37a585d032ca352923b24995f8cbf1a0 (patch) | |
| tree | 1805edc4fc79396de9150f8bc063888926d53d3b /components/script/dom/xrviewerpose.rs | |
| parent | 537958a3ccb57502c558e4da0963307fd7481a14 (diff) | |
| download | servo-25a0764a37a585d032ca352923b24995f8cbf1a0.tar.gz servo-25a0764a37a585d032ca352923b24995f8cbf1a0.zip | |
Use out parameter for generated methods returning JSVal (#34087)
* Make generated bindings that return a WebIDL `any` value use out parameters.
Returning raw JSVal values makes it easier to create GC hazards in code
that calls these methods. Accepting a MutableHandle argument instead
ensures that the values are rooted by the caller.
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
* Update mozjs.
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
* Fix clippy warnings.
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
---------
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
Diffstat (limited to 'components/script/dom/xrviewerpose.rs')
| -rw-r--r-- | components/script/dom/xrviewerpose.rs | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/components/script/dom/xrviewerpose.rs b/components/script/dom/xrviewerpose.rs index 92d2b03b54d..9c8774c7855 100644 --- a/components/script/dom/xrviewerpose.rs +++ b/components/script/dom/xrviewerpose.rs @@ -7,6 +7,7 @@ use euclid::RigidTransform3D; use js::conversions::ToJSValConvertible; use js::jsapi::Heap; use js::jsval::{JSVal, UndefinedValue}; +use js::rust::MutableHandleValue; use webxr_api::{Viewer, ViewerPose, Views}; use crate::dom::bindings::codegen::Bindings::XRViewBinding::XREye; @@ -189,7 +190,7 @@ impl XRViewerPose { impl XRViewerPoseMethods for XRViewerPose { /// <https://immersive-web.github.io/webxr/#dom-xrviewerpose-views> - fn Views(&self, _cx: JSContext) -> JSVal { - self.views.get() + fn Views(&self, _cx: JSContext, mut retval: MutableHandleValue) { + retval.set(self.views.get()) } } |